.end overwrites res.body with the last character

[ErisDS]

I've been experimenting with reqresnext as a way to write performant tests against express.

Today I ran into a weird issue where I suddenly started only getting the very last character of my content 🤔

It was happening every time I wired up express-session to my express app. It seems that once you add session handling both res.write and res.end are called internally.

The code here in reqresnext overwrites body on res.end rather than concatenating and res.end is only getting called with the final character.

My minimal repo case looks something like this:

// app.js
const express = require('express');
const session = require('express-session');

const app = express();

app.use(express.json());

app.use(session({
    secret: 'verysecretstring',
    name: 'testauth'
}));

app.get('/', (req, res) => {
    return res.send('Hello World!');
});

// reqres.js

const {Request, Response} = require('reqresnext');

const app = require('./app.js');

const req = new Request(Object.assign({}, {url: '/', method: 'GET'}, {app}));
const res = new Response(Object.assign({}, {}, {app, req}));

res.on('finish', () => {
    const text = res.body.toString('utf8');

    console.log('TEXT', text);
});

app(req, res);

You'll get "TEXT !" as the output.

If you comment out the lines

app.use(session({
    secret: 'verysecretstring',
    name: 'testauth'
}));

You'll get "TEXT Hello World!" as expected.

I'm able to fix it by changing adding this to reqres.js

    if (chunk) {
        res.write(chunk, encoding);
    }
    res.emit('finish');
    return this;
};

[antongolub]

🎉 This issue has been resolved in version 1.6.5 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• v1.6.5

Your semantic-release bot 📦🚀