Added unpipe as a noop to request #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes antongolub#29 - this adds a new type of test showing what happens when req and res are used in conjunction with express - added a noop for unpipe, which fixes the broken test
|
Reasonable. Thanks for the improvement. |
antongolub
pushed a commit
that referenced
this pull request
Jan 27, 2022
## [1.6.6](v1.6.5...v1.6.6) (2022-01-27) ### Bug Fixes * added unpipe as a noop to request ([#30](#30)) ([2326dce](2326dce))
|
🎉 This PR is included in version 1.6.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks! Following your instructions in the other PR I got everything working locally. Think I wasn’t clear but the first test in this PR breaks without the noop. Everything’s working nicely now, thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29