Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reg exp #9

Merged
merged 5 commits into from Jun 7, 2021
Merged

fix: reg exp #9

merged 5 commits into from Jun 7, 2021

Conversation

chinsun9
Copy link
Contributor

@chinsun9 chinsun9 commented Jun 6, 2021

fixed #5

Modify a regular expression to work with these cases below

import tmp from '../tmp';
import tmp from '../../../tmp';
import tmp from 'tmp';

image

import tmp from '../tmp';
import tmp from '../../../tmp';
import tmp from 'tmp';
@antongolub
Copy link
Owner

@chinsun9,

Nice improvement, thanks! Could you also add a test for this?
Add https://github.com/antongolub/tsc-es2020-fix/compare/test-for-pr-9 or smth similar, and run jest -u.

cd src/test/fixtures/ts-project && tsc -p tsconfig.es5.json &&  tsc -p tsconfig.es6.json
@chinsun9
Copy link
Contributor Author

chinsun9 commented Jun 7, 2021

@antongolub

result..?
before after


It's my first time writing a test code.
Is this right? 😂

Copy link
Owner

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antongolub
Copy link
Owner

antongolub commented Jun 7, 2021

@chinsun9,

You are on the right track ) Everything seems fine. Thanks.

@antongolub antongolub merged commit 3e2c476 into antongolub:master Jun 7, 2021
github-actions bot pushed a commit that referenced this pull request Jun 7, 2021
## [1.1.2](v1.1.1...v1.1.2) (2021-06-07)

### Bug Fixes

* add upper relative paths for repl regex ([#9](#9)) ([3e2c476](3e2c476))
@antongolub
Copy link
Owner

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ext prefix for non-default entries of external modules
2 participants