Python 3 conversion #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the string/bytes conversion needed to work with python3 All modules tested (except lateral) and responding as they did with 2.7 on an IIS10 box
Now using bytes for both XOR and AES encrypt methods. Decrypt now returns str. This allows both encryption methods to use the _encrypt_request successfully without encoding issues.
This reverts commit de18c20.
|
This PR looks very good, thanks for your contribution! I will test the changes in my labs ASAP and will fix/merge accordingly. I will keep updated this thread. |
|
I made some tests and there are still some broken functionalities (AES, SharPyShellPrompt and download module). Anyway it partially works, so i'm merging it into the py3 branch and i will fix what is remaining. Keep an eye on the commits of the branch https://github.com/antonioCoco/SharPyShell/tree/py3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Python3 (#10 ) and handling all the byte/string changes to ensure the encryption (XOR and AES) continues to work.
I've successfully tested with Python 3.9.2 (Kali) against IIS 10.0.19041.1 (Windows 10 Pro 21H1 19043.1110). I ran tests with the original ShaPyShell (Python 2.7) to compare results with my changes as well as with Windows Defender both enabled and disabled. The usage seems to be identical now between this version and the older 2.7 version.
All modules were tested and function as expected except for lateral_wmi due to testing limitations.