FP Refactor #28
Open
FP Refactor #28
+1,085
−857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work In Progress: Migration of artist logic to the new FP approach
Improved Gradle build configuration and updated many dependencies
… code. Partial corrections to tests (still do not work / compile)
Initial attempt to refactor datasets (now datasources) and repository…
…r success over chained promises
…he biggest missing part is a proper implementation of CloudAlbumDataSource::requestTopAlbums()). Removed unused classes and libraries for buses, interactors and jobs. Some additional minor changes and simplifications.
Partial conversion of the top albums logic to the functional style (the biggest...
…roject code using the default Android Studio 2.3 code style to make the project more coherent in terms of formatting.
Some performance improvements to NonEmptyList. Refactored the whole p…
added 3 commits
March 5, 2017 02:55
# Conflicts: # tools/src/main/java/com/finecinnamon/predef.kt
# Conflicts: # tools/src/main/java/com/finecinnamon/predef.kt
jrgonzalezg
force-pushed
the
rr-fp-refactor
branch
2 times, most recently
from
257f23e
to
9ccc98f
Compare
|
@jrgonzalezg thanks for keeping this up to date! |
…ine enabling from build.gradle files to gradle.properties
…mmutable proposal that are based on PCollections
jrgonzalezg
force-pushed
the
rr-fp-refactor
branch
from
0d27c86
to
77b4467
Compare
…yle and import optimizer to the whole project.
jrgonzalezg
force-pushed
the
rr-fp-refactor
branch
from
b429166
to
b29ffb6
Compare
|
How is this going ? Could you add some kind of detailed description for the current status please? I am working on some playground project and I have taken a lot of logic from this PR but I got some stuff broken and cannot figure out what's exacly happening :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
This is a sample proof of concept refactoring the app to use a monad transformer stack pushing Kotlin as much as it can go with FP and functional combinators. This PR will remain as such as is not intended to be merged but showcases a different style of coding in Kotlin similar to that found in Scala or Haskell.
The obvious limitation is the lack of support for Higher Kinds having to implement manually most of the combinators found on types such as
EitherT[F[_], L, R]as part of theResulttype.