Empty drawer

[alx5962]

Hi!
I just compiled this app on Android Studio and it's running fine excepted the navigation drawer which is empty. I checked the XML and there's a ListView so it should be nice to have data here.
XML is also missing android:fitsSystemWindows="true".

[antoniolg]

It's done on purpose, it's not the focus of this repo to learn how to use the menu drawer, only to explain the use of appcomat to use the material theme in previous Android versions.

[alx5962]

But then it looks like a bug as it is empty.
Drawer is designed in a new way with Material Design:
http://www.google.com/design/spec/patterns/navigation-drawer.html
It would be very nice if you could update your demo with at least a minimal
content (like a ripple effect).

2014-11-14 9:57 GMT+01:00 Antonio Leiva notifications@github.com:

It's done on purpose, it's not the focus of this repo to learn how to use
the menu drawer, only to explain the use of appcomat to use the material
theme in previous Android versions.

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

[antoniolg]

Yeah, I understand the point. This example was created to support the explanation of this post: http://antonioleiva.com/material-design-everywhere/

And I don't cover anything about menu drawers there. Maybe I write something about menu drawers and update this code, but not sure if that will happen and when. If you like, you could make a PR to this code and I'll feel glad to review and merge.

[alx5962]

I understand your point too of course :)
I really liked your sample BTW, as it helped me a lot to undestand how
appcompat works so thank you for this. Last week, I cloned your code and
added some data (as I wanted to display a ripple effect on my listview).
But the end result is sluggish (on my Nexus5 !) and I haven't found a way
to change the default selected color on v21 (I tried a lot of different
values in listSelector but nothing happens). I need to check if it's now
fixed on my N5 as I just got the final release of Lollipop yesterday.

2014-11-14 10:19 GMT+01:00 Antonio Leiva notifications@github.com:

Yeah, I understand the point. This example was created to support the
explanation of this post:
http://antonioleiva.com/material-design-everywhere/

And I don't cover anything about menu drawers there. Maybe I write
something about menu drawers and update this code, but not sure if that
will happen and when. If you like, you could make a PR to this code and
I'll feel glad to review and merge.

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

[paulvi]

ref #11 OK, so the drawer won't be empty after someone makes PR to fix that.

[antoniolg]

As I said, this is totally intentional, not an error to fix, because it's not the purpose of the example. If I have some time, I'll end up doing it because many people request it, but I'm not planning to create a full functional app from this example, just explain how to use AppCompat.