Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #160 where the lib will always default to the Imagick backend #166

Closed
wants to merge 1 commit into from
Closed

Fix issue #160 where the lib will always default to the Imagick backend #166

wants to merge 1 commit into from

Conversation

JC5
Copy link

@JC5 JC5 commented Mar 30, 2022

Fix #160

@antonioribeiro
Copy link
Owner

Not sure if this is the way to go on this one, because you are ignoring the first parameter of the parent constructor:

public function __construct($qrCodeService = null, $imageBackEnd = null)
{
    $this->setQrCodeService(
        empty($qrCodeService)
            ? $this->qrCodeServiceFactory($imageBackEnd)
            : $qrCodeService
    );
}

@JC5
Copy link
Author

JC5 commented Jun 14, 2022

Ah, I see the constructor changed from 1.0.3 onwards. Thanks for the constructive feedback as always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You need to install the imagick extension to use this back end, even on 2.0.1
2 participants
@JC5 @antonioribeiro