Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from SweetAlert to SweetAlert2 #230

Merged
merged 3 commits into from
Oct 17, 2020
Merged

Switch from SweetAlert to SweetAlert2 #230

merged 3 commits into from
Oct 17, 2020

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Oct 15, 2020

I would like to propose to switch from SweetAlert to SweetAlert2 - the supported fork of SweetAlert. The original reason for creating SweetAlert2 is inactivity of SweetAlert: https://stackoverflow.com/a/27842854/1331425

Documentation for SweetAlert2: https://sweetalert2.github.io/

Reasons to switch:

  1. Accessibility (WAI-ARIA) - SweetAlert2 is fully WAI-ARIA compatible and supports all popular screen-readers. Accessibility is a must in 2020, there are a lot of explanatory and tech articles, but this one is truly inspirable: Software development 450 words per minute

  2. Better support, average time to resolve an issue:

    • SweetAlert:
    • SweetAlert2:
  3. SweetAlert2 is far more popular and battle-tested that SweetAlert:

    • SweetAlert:
    • SweetAlert2:
  4. SweetAlert2 is dependency free, SweetAlert has 2.


Also removed the package-lock.json file per Yarn's recommendation:

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

@antonioribeiro antonioribeiro merged commit 5061e38 into antonioribeiro:master Oct 17, 2020
antonioribeiro added a commit that referenced this pull request Apr 17, 2023
…lert2

Switch from SweetAlert to SweetAlert2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants