Fixing undefined entity on node remove #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lindsay89
force-pushed
the
hotfix/undefined-entity-on-remove
branch
7 times, most recently
from
1c13650
to
ec047df
Compare
antonioru
reviewed
Oct 22, 2020
docs/dynamic-nodes.md
Outdated
| const [nodeId, setNodeId] = useState(schema.nodes.length+1); | ||
| const deleteNodeFromSchema = (id) => { | ||
| const nodeToRemove = schema.nodes.find(node => node.id === id); | ||
| removeNode(nodeToRemove); |
src/Diagram/Diagram.js
Outdated
| @@ -34,6 +34,13 @@ const Diagram = (props) => { | |||
| nodeRefs[nodeId] = nodeEl; | |||
| }; | |||
|
|
|||
| // when a node is deleted, remove its references | |||
| const onNodeRemove = (nodeId, inputsPorts, outputsPorts) => { | |||
There was a problem hiding this comment.
perhaps we can use useCalback?
src/hooks/useSchema/schemaReducer.js
Outdated
| @@ -19,16 +20,23 @@ const schemaReducer = (state, action) => { | |||
| nodes: state.nodes || [], | |||
| links: state.links || [], | |||
| }); | |||
| case ON_NODE_REMOVE: | |||
| case ON_NODE_REMOVE: { // remove all node's links | |||
| let linksToKeep = []; | |||
There was a problem hiding this comment.
let nextLinks = state.links || [];
tests/DiagramNode.spec.js
Outdated
| @@ -5,6 +5,7 @@ import DiagramNode from '../dist/Diagram/DiagramNode/DiagramNode'; | |||
|
|
|||
| describe('DiagramNode component', () => { | |||
| afterEach(cleanup); | |||
| sinon.restore(); | |||
There was a problem hiding this comment.
afterEach(() => {
clearnup();
sinon.restore();
});
Lindsay89
force-pushed
the
hotfix/undefined-entity-on-remove
branch
3 times, most recently
from
b3aa847
to
772270b
Compare
Lindsay89
force-pushed
the
hotfix/undefined-entity-on-remove
branch
from
772270b
to
b5f85c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix consists in removing the links associated with a node, when this one deleted.
Related Issue
#33