Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@types): fixed custom data diagrams #42

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix(@types): fixed custom data diagrams #42

merged 1 commit into from
Nov 6, 2020

Conversation

9renpoto
Copy link
Contributor

@9renpoto 9renpoto commented Nov 4, 2020 •
edited

Description

  • fixed Diagram generic types

Related Issue

Motivation and Context

How Has This Been Tested?

yarn test-types

Screenshots (if appropriate):

❯ yarn test-types
yarn run v1.22.10
$ npx tsc -p . --noEmit
✨  Done in 4.32s.

@9renpoto 9renpoto marked this pull request as ready for review November 4, 2020 09:44
@9renpoto
Copy link
Contributor Author

9renpoto commented Nov 4, 2020

@antonioru Hi, can you review ? :)

@antonioru
Copy link
Owner

Hi @9renpoto
thank you very much for your PR and for the effort to keep a good TS types!
I'm happy to approve

@antonioru antonioru merged commit 4c1cf03 into antonioru:master Nov 6, 2020
@9renpoto 9renpoto deleted the feature/types branch November 7, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@9renpoto @antonioru