Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dash(-) in song title or artist #1

Closed
antoniouaa opened this issue Aug 29, 2019 · 2 comments
Closed

Dash(-) in song title or artist #1

antoniouaa opened this issue Aug 29, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@antoniouaa
Copy link
Owner

Due to the website used in the GET request for the lyrics and their complete lack of consistency in naming their html pages using dashes, having dashes in the title of the song or artist trips the script up and fetches no lyrics.

Returns "No song found", which is suboptimal to be frank.

Guess we won't be reading Playboi Carti's lyrics.
bad_bad_website
@antoniouaa antoniouaa assigned antoniouaa and unassigned antoniouaa Aug 29, 2019
@antoniouaa antoniouaa added the bug Something isn't working label Aug 29, 2019
@antoniouaa
Copy link
Owner Author

Playboi Carti's name has been hardcoded.
I couldn't find any pattern regarding dashes in artist names, so we'll roll with this for now.

@antoniouaa
Copy link
Owner Author

Issue resolved by ditching azlyrics as a source and using Google's smart lyric boxes instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antoniouaa