Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression after upgrade to 1.16.1 #607

Closed
fggarcia opened this issue Mar 18, 2024 · 0 comments
Closed

Performance regression after upgrade to 1.16.1 #607

fggarcia opened this issue Mar 18, 2024 · 0 comments

Comments

@fggarcia
Copy link

Hi @antonmedv @bizywizy Benchmarking 1.16.0 and 1.16.1 i have this result.

version 1.16.0

pkg: github.com/melisource/rule-engine-api/src/api/expression
BenchmarkExprLanguage-8            72614             16105 ns/op           19614 B/op        215 allocs/op
BenchmarkExprLanguage-8            77490             15433 ns/op           19615 B/op        215 allocs/op
BenchmarkExprLanguage-8            77436             15527 ns/op           19616 B/op        215 allocs/op
BenchmarkExprLanguage-8            77794             15175 ns/op           19614 B/op        215 allocs/op
BenchmarkExprLanguage-8            77324             15553 ns/op           19615 B/op        215 allocs/op
PASS

version 1.16.1

BenchmarkExprLanguage-8             3126            333489 ns/op           19492 B/op        214 allocs/op
BenchmarkExprLanguage-8             3728            323352 ns/op           19493 B/op        214 allocs/op
BenchmarkExprLanguage-8             3729            338181 ns/op           19491 B/op        214 allocs/op
BenchmarkExprLanguage-8             3735            321381 ns/op           19494 B/op        214 allocs/op
BenchmarkExprLanguage-8             3744            322084 ns/op           19487 B/op        214 allocs/op
PASS

cpu pprof
version 1.16.0
image

version 1.16.1
image

@expr-lang expr-lang locked and limited conversation to collaborators Mar 18, 2024
@antonmedv antonmedv converted this issue into discussion #608 Mar 18, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant