-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] add --indent
CLI arg; add tabs support
#126
Conversation
I don’t like adding more flags to fx. Can we use .fxrc cars for this setting? |
I'm not sure why using npm packages would meaningfully increase startup time, but sure, that's up to you. As for flags - |
It will. How you suppose it can be done without extra costs? For example adding yargs adds around 50 ms delay. And I trying to keep fx under 100 ms startup time.
Yes, env is better. Also can you support other params too? |
Sure, what'd you have in mind? Most of the config things are functions (impossible to support via env vars), or shell colors (awkward to support via env vars), so this seems like the only one. |
Hmmm, yes. You are right. Let's find some solutions. Maybe completely refactor to env instead of function? |
That's certainly an approach - but it might be better to wait for a use case to present itself before creating churn, and i'm sure |
I rewrote the entire fx in golang. So I belove this PR is no longer actual. |
@antonmedv does it have |
Will have FX_INDENT env variable. |
Right now fx has themes support with FX_THEME. So I'm going to add FX_INDENT as well. BTW, fx still supports JS reducerts and .fxrc file. |
Fixes #121
Happy to add tests and usage examples if this is the right direction to be going.
(Separately, i think thinks would be a lot cleaner if you used something like yargs as an arg parser, but that's out of scope for this PR)