Fixed "KeyError None" #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+547
to
+551
| if genderType == None: | ||
| genderId = None | ||
| else: | ||
| genderId = monica.getGenderMapping()[genderType] | ||
|
|
There was a problem hiding this comment.
I think this should also work and it's a bit shorter 😃
Can you confirm this?
Suggested change
| if genderType == None: | |
| genderId = None | |
| else: | |
| genderId = monica.getGenderMapping()[genderType] | |
| genderId = monica.getGenderMapping().get(genderType, None) |
|
Hi @Turochamp |
antonplagemann
added a commit
that referenced
this pull request
Dec 9, 2021
Co-authored-by: Michael Åhs <michael.ahs@vipps.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @antonplagemann
When doing full sync a few of my contacts failed with the error: "Script aborted: KeyError: None". The cause is an assumption in the code that
genderTypenever is null, something this change fixes.I do now know why these contacts' gender was null. They look perfectly fine in Monica.