Feature/scribe 4 #59
Merged
Feature/scribe 4 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass now). (#58) Updated plugin version to 4.0.0 due to breaking changes: - All Scribe classes have been moved to new packages. This means most clients will have to change provider configuration. For example, `org.scribe.builder.api.FacebookApi` is now `com.github.scribejava.apis.FacebookApi`. - Some method signatures in OauthService.groovy have changed to take into account the differences between OAuth 1 and OAuth 2 in the new Scribe Java. Also, some of the dynamic methods now dispatch to one version or another based on the number of arguments received. - Clients that make use of Scribe Java directly might have to add the API dependency explicitly: `compile 'com.github.scribejava:scribejava-apis:4.0.0'` The changes were made somewhat blindly, without a deep understanding of OAuth - the minimum to make the tests pass and enable login with Facebook and Google.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.