Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

benmccann
Copy link
Contributor

Updates the package-lock to get rid of some warnings on the console

@Conduitry
Copy link

As a template, I don't think a lockfile belongs in here at all.

As a generic IE template, I'd argue @beyonk/sapper-httpclient also doesn't really belong here.

The command in the npm script to manually copy over the dev version of shimport also should be removed, and won't work on Windows anyway.

@benmccann
Copy link
Contributor Author

I guess it depends if you think of it as a template or an example project. I'm fine either way

I just sent a PR for the shimport thing: #13

@antony
Copy link
Owner

antony commented Sep 18, 2020

The reason @beyonk/sapper-httpclient was in here is because it was a library which caused me specific trouble during my first attempt at making an IE-ready Sapper template. It can probably be replaced with some specific troublesome lines of JS now, or a node_module doing something similar. It's a way of testing that the babel config still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants