New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup babel-preset-cra-universal #129
Setup babel-preset-cra-universal #129
Conversation
Implemented custom babel preset based on [babel-preset-razzle](https://github.com/jaredpalmer/razzle/tree/master/packages/babel-preset-razzle). Only name changes occurred.
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 67 67
Branches 13 13
=====================================
Hits 67 67 Continue to review full report at Codecov.
|
Hi, thanks for the PR! 🎉 Since cra-universal already used Babel 7, we also must use some of their official scoped packaged The presets and plugins used: This is the presets and plugins dependency list: Let me know if you need any help. |
"babel-plugin-transform-react-remove-prop-types": "0.3.2", | ||
"babel-plugin-transform-runtime": "6.23.0", | ||
"babel-preset-env": "1.3.3", | ||
"babel-preset-react": "6.23.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the package should use @babel
scoped package, example: @babel/preset-env
, @babel/preset-react
Hi @ajchili , any updates on this? |
Hey, I still plan to get this done but got swamped with other work.
Tomorrow or Thursday I should have amendments.
…On Tue, Nov 27, 2018 at 8:19 PM Antony Budianto ***@***.***> wrote:
Hi @ajchili <https://github.com/ajchili> , any updates on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#129 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHi5d88Eh1cyjO5e-8JlllVtosvsy3U0ks5uzeSvgaJpZM4YqI2Z>
.
|
Cool @ajchili , thanks for the update, just let me know if you need some help 👍 |
Made the requested changes. I hope I did them right. If not I may need some help as I am still learning what a babel preset is and how to create one. |
Thanks, let me fix some of the dependencies |
Followed suggestion from #128 to implement a custom Babel preset. This is a copy of babel-preset-razzle and only offers name changes to the babel-preset-razzle. Should there be any changes needed feel free to request them for this PR and I will try to get to them asap 🙂