Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat filters as form so we can press enter to submit #172

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

gempir
Copy link
Contributor

@gempir gempir commented Jun 22, 2022

In #101 there are some keyboard shortcuts defined. I personally really like to use Enter to apply filters.

I can't test this sadly because my local tad fails to start after following the building instructions

App threw an error during load
Error: dlopen(/Users/[...]/dev/tad/node_modules/ac-node-duckdb/build/Release/node-duckdb-addon.node, 1): Library not loaded: /usr/local/opt/openssl@3/lib/libcrypto.3.dylib
  Referenced from: /Users/[...]/dev/tad/node_modules/ac-node-duckdb/build/Release/node-duckdb-addon.node
  Reason: image not found

But I've written this sort of feature in tons of web apps so I assume this will work here as well.

@gempir gempir changed the title treat filters as form so we can't press enter to submit Treat filters as form so we can press enter to submit Jun 22, 2022
@antonycourtney
Copy link
Owner

Hi @gempir
Thanks for the PR! I'll give it a try.

Sorry that you're hitting difficulties with your local Tad build. Can you please try the following (assuming you are on a Mac):

  1. Install openssl from homebrew:
$ brew install openssl@3
  1. Add the following to your shell profile (for me, this is in my ~/.bash_profile):
# OpenSSL stuff:
export PATH="/usr/local/opt/openssl@3/bin:$PATH"
export LDFLAGS="-L/usr/local/opt/openssl@3/lib"
export CPPFLAGS="-I/usr/local/opt/openssl@3/include"
export PKG_CONFIG_PATH="/usr/local/opt/openssl@3/lib/pkgconfig"

Hope that helps get your local build working. Would be grateful if you could try and let me know either way so I can debug further or update the build instructions. Thanks!

@gempir
Copy link
Contributor Author

gempir commented Jun 23, 2022

@antonycourtney Yes! That did the trick. I can run tad now.

I could also confirm that my little feature works and Enter now applies Filters :)

@gempir
Copy link
Contributor Author

gempir commented Jul 27, 2022

@antonycourtney anything further I can do to to get this merged?

@antonycourtney
Copy link
Owner

Loooong overdue (sincere apologies), but this is (still!) a good change. Merging...

@antonycourtney antonycourtney merged commit 8fec6ac into antonycourtney:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants