Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT mark is not realized correctly #3583

Closed
hongliangl opened this issue Apr 5, 2022 · 1 comment · Fixed by #3630
Closed

CT mark is not realized correctly #3583

hongliangl opened this issue Apr 5, 2022 · 1 comment · Fixed by #3630
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@hongliangl
Copy link
Contributor

Describe the bug
CT mark defined in pkg/agent/openflow/field.go like NotServiceCTMark = binding.NewOneBitZeroCTMark(4) is used in a flow as the following:

ConntrackCommitTable.ofTable.BuildFlow(priorityNormal).
		Cookie(cookieID).
		MatchProtocol(ipProtocol).
		MatchCTStateNew(true).
		MatchCTStateTrk(true).
		MatchCTMark(NotServiceCTMark).
		Action().CT(true, ConntrackCommitTable.GetNext(), f.ctZones[ipProtocol], f.ctZoneSrcField).
		MoveToCtMarkField(PktSourceField, ConnSourceCTMarkField).
		CTDone().
		Done(),

The flow should to be like the following:

cookie=0xf010000000000, table=28, priority=200,ct_mark=0x0/0x10, ct_state=+new+trk,ip actions=ct(commit,table=29,zone=65520,exec(move:NXM_NX_REG0[0..3]->NXM_NX_CT_MARK[0..3]))

But it is:

cookie=0xf010000000000, table=28, priority=200,ct_state=+new+trk,ip actions=ct(commit,table=29,zone=65520,exec(move:NXM_NX_REG0[0..3]->NXM_NX_CT_MARK[0..3]))

As a result, the CT mark is not realized in the flow.

@hongliangl hongliangl added the kind/bug Categorizes issue or PR as related to a bug. label Apr 5, 2022
@wenyingd
Copy link
Contributor

wenyingd commented Apr 13, 2022

Hi @hongliangl , this is introduced by an issue in the dependent library ofnet. I have made a fix and it is merged now (antrea-io/ofnet#30). Please update go.mod with ofnet version 0.5.7+, and the fix would be involved.

hongliangl added a commit to hongliangl/antrea that referenced this issue Apr 13, 2022
Fix antrea-io#3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this issue Apr 13, 2022
Fix antrea-io#3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
tnqn pushed a commit that referenced this issue Apr 14, 2022
Fix #3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this issue Apr 29, 2022
Fix antrea-io#3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this issue May 10, 2022
Fix antrea-io#3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this issue May 10, 2022
Fix antrea-io#3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this issue May 10, 2022
Fix antrea-io#3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this issue May 11, 2022
Fix antrea-io#3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
tnqn pushed a commit that referenced this issue May 11, 2022
Fix #3583

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants