[IPv6] Add IPv6 support in NetworkPolicy #1272

wenyingd · 2020-09-18T12:18:47Z

Add support for IPv6 addresses in Network Policy.

antrea-bot · 2020-09-18T12:19:02Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

codecov-commenter · 2020-09-21T10:56:20Z

Codecov Report

Merging #1272 into ipv6 will increase coverage by 0.05%.
The diff coverage is 70.31%.

@@            Coverage Diff             @@
##             ipv6    #1272      +/-   ##
==========================================
+ Coverage   57.88%   57.93%   +0.05%     
==========================================
  Files         155      155              
  Lines       13034    13164     +130     
==========================================
+ Hits         7545     7627      +82     
- Misses       4685     4726      +41     
- Partials      804      811       +7

Flag	Coverage Δ
#kind-e2e-tests	`45.95% <44.14%> (-0.27%)`	⬇️
#unit-tests	`41.72% <55.32%> (+0.18%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/antctl/transform/common/transform.go	`0.00% <0.00%> (ø)`
pkg/apis/controlplane/helper.go	`0.00% <0.00%> (ø)`
pkg/apis/controlplane/v1beta1/sets.go	`36.76% <0.00%> (ø)`
pkg/agent/openflow/client.go	`42.22% <44.44%> (+0.36%)`	⬆️
pkg/apis/controlplane/v1beta1/helper.go	`38.46% <50.00%> (-7.70%)`	⬇️
pkg/util/ip/ip.go	`68.42% <55.55%> (+1.75%)`	⬆️
pkg/ovs/openflow/ofctrl_builder.go	`59.12% <66.66%> (+0.08%)`	⬆️
pkg/agent/openflow/network_policy.go	`68.55% <68.85%> (-0.63%)`	⬇️
pkg/agent/openflow/pipeline.go	`61.44% <75.59%> (+0.68%)`	⬆️
pkg/agent/controller/networkpolicy/reconciler.go	`67.13% <100.00%> (+0.47%)`	⬆️
... and 6 more

wenyingd · 2020-09-24T01:14:59Z

/test-ipv6-e2e

wenyingd · 2020-09-28T11:38:15Z

/test-ipv6-e2e
/test-ipv6-only-e2e

jianjuns

Would you consider changing the commit message to: Add IPv6 support for NetworkPolicy

jianjuns · 2020-09-28T20:26:59Z

pkg/apis/controlplane/types.go

@@ -57,7 +57,7 @@ type GroupMemberPod struct {
 	// Pod maintains the reference to the Pod.
 	Pod *PodReference
 	// IP maintains the IPAddress of the Pod.
-	IP IPAddress


This seems an incompatible API group change. @tnqn

Yes, unversioned type can be changed any time, but v1beta1 type cannot be changed in this way directly. otherwise it breaks backwards compatibility. I think v1beta2.GroupMember supports multiple IPs per Pod, you could base on it.

The controlplane.v1beta2 API is here #1405

Having some offline discussion with Quan, I will rebase the change on v1beta2. Since the PR to upgrade v1beta1 to v1beta2 is not merged yet, will rebase the code after that PR is ready.

pkg/agent/openflow/pipeline.go

wenyingd · 2020-09-30T05:24:23Z

/test-all
/test-ipv6-e2e

codecov-io · 2020-10-12T08:10:24Z

Codecov Report

Merging #1272 into ipv6 will decrease coverage by 17.07%.
The diff coverage is 62.70%.

@@             Coverage Diff             @@
##             ipv6    #1272       +/-   ##
===========================================
- Coverage   58.95%   41.87%   -17.08%     
===========================================
  Files         157       85       -72     
  Lines       13072    10734     -2338     
===========================================
- Hits         7706     4495     -3211     
- Misses       4552     5838     +1286     
+ Partials      814      401      -413

Flag	Coverage Δ
#kind-e2e-tests	`?`
#unit-tests	`41.87% <62.70%> (+0.34%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/agent/util/net.go	`35.89% <ø> (-16.38%)`	⬇️
pkg/apis/controlplane/helper.go	`0.00% <0.00%> (ø)`
pkg/apis/controlplane/sets.go	`0.00% <0.00%> (-15.39%)`	⬇️
pkg/agent/openflow/client.go	`10.92% <22.22%> (-30.95%)`	⬇️
pkg/util/ip/ip.go	`67.24% <41.66%> (-12.39%)`	⬇️
...ntroller/networkpolicy/networkpolicy_controller.go	`70.22% <50.00%> (-11.15%)`	⬇️
pkg/agent/openflow/pipeline.go	`25.19% <62.12%> (-38.22%)`	⬇️
pkg/agent/openflow/network_policy.go	`63.09% <70.68%> (-10.45%)`	⬇️
pkg/agent/controller/networkpolicy/reconciler.go	`67.74% <100.00%> (-1.43%)`	⬇️
pkg/agent/agent_linux.go	`0.00% <0.00%> (-100.00%)`	⬇️
... and 125 more

lzhecheng · 2020-10-21T08:57:29Z

/test-ipv6-networkpolicy
/test-ipv6-only-networkpolicy

abhiraut

minor comment in addition to the changes needed to support v1beta2 for control plane APIs

pkg/agent/controller/networkpolicy/reconciler.go

lzhecheng · 2020-10-22T02:15:57Z

/test-ipv6-networkpolicy
/test-ipv6-only-networkpolicy

vmwclabot added the cla-not-required label Sep 18, 2020

wenyingd force-pushed the ipv6_networkpolicy branch from 9a2af81 to de2efe5 Compare September 18, 2020 12:27

wenyingd force-pushed the ipv6 branch 2 times, most recently from 1c94652 to 15eea1d Compare September 21, 2020 07:15

wenyingd force-pushed the ipv6_networkpolicy branch from de2efe5 to f0f069f Compare September 21, 2020 10:52

wenyingd force-pushed the ipv6_networkpolicy branch 2 times, most recently from ffc1e77 to 90d2f6c Compare September 23, 2020 13:40

wenyingd force-pushed the ipv6_networkpolicy branch 2 times, most recently from 0297228 to 82870ac Compare September 25, 2020 11:10

wenyingd changed the title ~~[WIP][IPv6] Add enhancement in NetworkPolicy to support IPv6~~ [IPv6] Add enhancement in NetworkPolicy to support IPv6 Sep 25, 2020

wenyingd force-pushed the ipv6 branch from 15eea1d to cf688b3 Compare September 25, 2020 12:26

wenyingd force-pushed the ipv6_networkpolicy branch 2 times, most recently from 9969d93 to 62043fb Compare September 28, 2020 11:36

wenyingd force-pushed the ipv6_networkpolicy branch from 62043fb to 1de8152 Compare September 28, 2020 12:21

jianjuns requested review from Dyanngg and abhiraut September 28, 2020 20:22

jianjuns reviewed Sep 28, 2020

View reviewed changes

wenyingd force-pushed the ipv6 branch from c5577c2 to ccad6ea Compare September 29, 2020 07:06

wenyingd force-pushed the ipv6_networkpolicy branch from 1de8152 to a9bf3a9 Compare September 29, 2020 11:58

wenyingd changed the title ~~[IPv6] Add enhancement in NetworkPolicy to support IPv6~~ [IPv6] Add IPv6 support in NetworkPolicy Sep 29, 2020

wenyingd requested a review from tnqn September 29, 2020 12:25

wenyingd force-pushed the ipv6_networkpolicy branch from a9bf3a9 to 0c78aef Compare September 30, 2020 03:25

wenyingd force-pushed the ipv6 branch from afbeacf to 8524090 Compare October 12, 2020 04:30

wenyingd force-pushed the ipv6_networkpolicy branch from 0c78aef to 2a0a24d Compare October 12, 2020 08:06

abhiraut reviewed Oct 21, 2020

View reviewed changes

pkg/agent/controller/networkpolicy/reconciler.go Show resolved Hide resolved

wenyingd force-pushed the ipv6 branch 5 times, most recently from ad98470 to 9fc5ebf Compare October 27, 2020 09:03

lzhecheng force-pushed the ipv6 branch 2 times, most recently from fc10cfc to 3c3ec42 Compare November 4, 2020 07:58

lzhecheng mentioned this pull request Nov 4, 2020

[IPv6] Add IPv6 support for NetworkPolicy by @wenyingd #1487

Merged

lzhecheng force-pushed the ipv6 branch 15 times, most recently from dd85a9e to 267d1c0 Compare November 11, 2020 09:24

lzhecheng closed this Nov 11, 2020

lzhecheng deleted the branch antrea-io:ipv6 November 11, 2020 23:10

Dyanngg mentioned this pull request Nov 18, 2020

Fix ARP flow not installed issue in networkpolicy-only mode #1575

Merged

wenyingd deleted the ipv6_networkpolicy branch August 2, 2021 03:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IPv6] Add IPv6 support in NetworkPolicy #1272

[IPv6] Add IPv6 support in NetworkPolicy #1272

wenyingd commented Sep 18, 2020

antrea-bot commented Sep 18, 2020

codecov-commenter commented Sep 21, 2020 •

edited

Loading

wenyingd commented Sep 24, 2020

wenyingd commented Sep 28, 2020

jianjuns left a comment

jianjuns Sep 28, 2020

tnqn Oct 19, 2020

Dyanngg Oct 19, 2020

wenyingd Oct 20, 2020

wenyingd commented Sep 30, 2020

codecov-io commented Oct 12, 2020 •

edited

Loading

lzhecheng commented Oct 21, 2020

abhiraut left a comment

lzhecheng commented Oct 22, 2020

[IPv6] Add IPv6 support in NetworkPolicy #1272

[IPv6] Add IPv6 support in NetworkPolicy #1272

Conversation

wenyingd commented Sep 18, 2020

antrea-bot commented Sep 18, 2020

codecov-commenter commented Sep 21, 2020 • edited Loading

Codecov Report

wenyingd commented Sep 24, 2020

wenyingd commented Sep 28, 2020

jianjuns left a comment

Choose a reason for hiding this comment

jianjuns Sep 28, 2020

Choose a reason for hiding this comment

tnqn Oct 19, 2020

Choose a reason for hiding this comment

Dyanngg Oct 19, 2020

Choose a reason for hiding this comment

wenyingd Oct 20, 2020

Choose a reason for hiding this comment

wenyingd commented Sep 30, 2020

codecov-io commented Oct 12, 2020 • edited Loading

Codecov Report

lzhecheng commented Oct 21, 2020

abhiraut left a comment

Choose a reason for hiding this comment

lzhecheng commented Oct 22, 2020

codecov-commenter commented Sep 21, 2020 •

edited

Loading

codecov-io commented Oct 12, 2020 •

edited

Loading