Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e network policy test #140

Closed
wants to merge 1 commit into from
Closed

Conversation

lzhecheng
Copy link
Contributor

This PR is to add a simple e2e network policy test. The testing network policy only allows traffic from pod with correct label.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests. This command can only be run by members of the vmware-tanzu organization
  • /skip-e2e: to skip e2e tests. This command can only be run by members of the vmware-tanzu organization

@vmwclabot
Copy link

@lzhecheng, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@lzhecheng
Copy link
Contributor Author

/test-e2e

@lzhecheng
Copy link
Contributor Author

/test-e2e

@tnqn
Copy link
Member

tnqn commented Nov 26, 2019

@lzhecheng thanks for working on this, but is the test case different from https://github.com/kubernetes/kubernetes/blob/master/test/e2e/network/network_policy.go? If not, I think we don't need to add duplicate ones, we should only add cases not covered by upstream tests. We can first enable the upstream ones.

@antoninbas
Copy link
Contributor

If the K8s network policy tests can be run as part of the Kind CI (#137) and complete in a few minutes, then I am also in favor of using these tests instead of merging this. If they take too long to run, then we should select a small subset of these tests to run for every commit. If this is not possible for some reason, then we should have our own test and merge this.

@tnqn
Copy link
Member

tnqn commented Nov 27, 2019

The K8s tests can be selected by focus and skip options which support regular expression, so doable if we only want to run a small subset of them. I didn't run them on Kind but I don't think there would be difference between home-grown tests and upstream tests for Kind.

@lzhecheng
Copy link
Contributor Author

Let's use conformance's network policy testcases and antrea specific network policy testcases. I will close this PR now.

@lzhecheng lzhecheng closed this Nov 28, 2019
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

zyiou pushed a commit to zyiou/antrea that referenced this pull request Jul 2, 2021
In exporting and collecting process, simplify the address input
consumption.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants