Add "antctl proxy" support #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
|
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
+ Coverage 67.85% 67.86% +0.01%
==========================================
Files 159 159
Lines 12829 12830 +1
==========================================
+ Hits 8705 8707 +2
- Misses 3203 3204 +1
+ Partials 921 919 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
force-pushed
the
antctl-proxy
branch
2 times, most recently
from
ad1331c
to
023ea20
Compare
|
antctl binary size increased by about 2% (50MB -> 51MB) with some small variations based on the platform |
jianjuns
reviewed
Oct 30, 2020
| @@ -384,3 +386,32 @@ results: | |||
| componentInfo: Output | |||
| action: Delivered | |||
| ``` | |||
|
|
|||
| ### Antctl Proxy | |||
There was a problem hiding this comment.
Would you mention antctl will get the controller/agent Node IP from K8s API, and connects to that IP?
There was a problem hiding this comment.
Good idea, updated that section
weiqiangt
reviewed
Oct 30, 2020
antoninbas
force-pushed
the
antctl-proxy
branch
from
5809c83
to
ec4a75c
Compare
tnqn
previously approved these changes
Oct 30, 2020
With this command antctl can operate as a reverse proxy for Antrea APIs, similarly to "kubectl proxy" for the K8s APIs (we rely on the k8s.io/kubectl Go module for the implementation). Thanks to this, troubleshooting the APIs can become much easier and we hide complexity from clients. One example is that it becomes much easier to use "go tool pprof". The drawback here is that the HTTPS connection between the proxy and the Antrea Agent / Controller is not secure (this can be fixed for the Controller at least); in this it is very similar to the supportbundle command implementation. Fixes antrea-io#1434
antoninbas
force-pushed
the
antctl-proxy
branch
from
ec4a75c
to
276bd0e
Compare
|
/test-all |
jianjuns
previously approved these changes
Oct 30, 2020
|
/test-all |
weiqiangt
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this command antctl can operate as a reverse proxy for Antrea APIs,
similarly to "kubectl proxy" for the K8s APIs (we rely on the
k8s.io/kubectl Go module for the implementation). Thanks to this,
troubleshooting the APIs can become much easier and we hide complexity
from clients. One example is that it becomes much easier to use "go tool
pprof". The drawback here is that the HTTPS connection between the proxy
and the Antrea Agent / Controller is not secure (this can be fixed for
the Controller at least); in this it is very similar to the
supportbundle command implementation.
Fixes #1434