Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VMware Harbor registry for flow-aggregator Docker image #1650

Conversation

antoninbas
Copy link
Contributor

Changes are the same as in
#1617 but for the
antrea/flow-aggregator Docker image.

There was also a typo in the flow-aggregator YAML: the image key didn't
match the one used in generate-manifest-flow-aggregator.sh when invoking
kustomize.

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (feature/flow-aggregator@a3f0042). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##             feature/flow-aggregator    #1650   +/-   ##
==========================================================
  Coverage                           ?   62.00%           
==========================================================
  Files                              ?      181           
  Lines                              ?    15411           
  Branches                           ?        0           
==========================================================
  Hits                               ?     9556           
  Misses                             ?     4836           
  Partials                           ?     1019           
Flag Coverage Δ
kind-e2e-tests 52.96% <0.00%> (?)
unit-tests 40.69% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@dreamtalen dreamtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Changes are the same as in
antrea-io#1617 but for the
antrea/flow-aggregator Docker image.

There was also a typo in the flow-aggregator YAML: the image key didn't
match the one used in generate-manifest-flow-aggregator.sh when invoking
kustomize.
@antoninbas antoninbas force-pushed the use-vmware-harbor-registry-for-flow-aggregator-image branch from 65893e8 to 3fc6580 Compare December 11, 2020 04:21
Copy link
Member

@srikartati srikartati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM

@antoninbas antoninbas merged commit c4ef415 into antrea-io:feature/flow-aggregator Dec 11, 2020
@antoninbas antoninbas deleted the use-vmware-harbor-registry-for-flow-aggregator-image branch December 11, 2020 19:43
srikartati pushed a commit to srikartati/antrea that referenced this pull request Dec 17, 2020
…o#1650)

Changes are the same as in
antrea-io#1617 but for the
antrea/flow-aggregator Docker image.

There was also a typo in the flow-aggregator YAML: the image key didn't
match the one used in generate-manifest-flow-aggregator.sh when invoking
kustomize.
srikartati pushed a commit to srikartati/antrea that referenced this pull request Dec 19, 2020
…o#1650)

Changes are the same as in
antrea-io#1617 but for the
antrea/flow-aggregator Docker image.

There was also a typo in the flow-aggregator YAML: the image key didn't
match the one used in generate-manifest-flow-aggregator.sh when invoking
kustomize.
srikartati pushed a commit to srikartati/antrea that referenced this pull request Dec 21, 2020
…o#1650)

Changes are the same as in
antrea-io#1617 but for the
antrea/flow-aggregator Docker image.

There was also a typo in the flow-aggregator YAML: the image key didn't
match the one used in generate-manifest-flow-aggregator.sh when invoking
kustomize.
srikartati pushed a commit to srikartati/antrea that referenced this pull request Dec 21, 2020
…o#1650)

Changes are the same as in
antrea-io#1617 but for the
antrea/flow-aggregator Docker image.

There was also a typo in the flow-aggregator YAML: the image key didn't
match the one used in generate-manifest-flow-aggregator.sh when invoking
kustomize.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants