Fix documentation for FQDN based policies which use Service DNS names #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
the
kind/documentation
|
LGTM. Thanks for fixing this. BTW did you want to set reviewers instead of assinees? |
that's right :), thanks |
abhiraut
previously approved these changes
Aug 27, 2021
docs/antrea-network-policy.md
Outdated
| endpoint backing the Service. For headless Services, a ClusterIP is not | ||
| allocated and, assuming the Service has a selector, the DNS server returns A / | ||
| AAAA records that point directly to the endpoints. In that case, FQDN based | ||
| policies can be used successfully. For example, the following policy will drop |
There was a problem hiding this comment.
Suggested change
| policies can be used successfully. For example, the following policy will drop | |
| policies can be used successfully. For example, the following exact name matching policy will drop |
?
GraysonWu
previously approved these changes
Aug 27, 2021
FQDN based policies cannot be used with "normal" (non headless Services) as the DNS records point to the ClusterIP, yet policies are enforced after AntreaProxy LB. Reported by @GraysonWu Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
doc-fqdn-policies-dont-work-with-services
branch
from
d75b39e
to
f2c52f8
Compare
|
/skip-all |
antoninbas
added a commit
that referenced
this pull request
Aug 30, 2021
…cies (#2679) FQDN based policies cannot be used with "normal" (non headless Services) as the DNS records point to the ClusterIP, yet policies are enforced after AntreaProxy LB. Reported by @GraysonWu Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FQDN based policies cannot be used with "normal" (non headless Services)
as the DNS records point to the ClusterIP, yet policies are enforced
after AntreaProxy LB.
Reported by @GraysonWu
Signed-off-by: Antonin Bas abas@vmware.com