Flexible pipeline - #1 Architecture #3035
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // Copyright 2021 Antrea Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package openflow | ||
|
|
||
| import ( | ||
| "antrea.io/antrea/pkg/agent/openflow/cookie" | ||
| binding "antrea.io/antrea/pkg/ovs/openflow" | ||
| ) | ||
|
|
||
| type featureEgress struct { | ||
| cookieAllocator cookie.Allocator | ||
|
|
||
| snatFlowCache *flowCategoryCache | ||
| hostNetworkingFlows []binding.Flow | ||
|
|
||
| enableProxy bool | ||
| } | ||
|
|
||
| func (c *featureEgress) getFeatureID() featureID { | ||
| return Egress | ||
| } | ||
|
|
||
| func newFeatureEgress(cookieAllocator cookie.Allocator, enableProxy bool) feature { | ||
| return &featureEgress{ | ||
| snatFlowCache: newFlowCategoryCache(), | ||
| cookieAllocator: cookieAllocator, | ||
| enableProxy: enableProxy, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| // Copyright 2021 Antrea Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package openflow | ||
|
|
||
| import ( | ||
| binding "antrea.io/antrea/pkg/ovs/openflow" | ||
| "antrea.io/antrea/pkg/util/runtime" | ||
| ) | ||
|
|
||
| func (c *featurePodConnectivity) getTemplate(protocol ofProtocol) *pipelineTemplate { | ||
| var template *pipelineTemplate | ||
| if protocol == ofProtocolIP { | ||
| template = &pipelineTemplate{ | ||
| stageTables: map[binding.StageID][]tableRequest{ | ||
| binding.ClassifierStage: { | ||
| tableRequest{ClassifierTable, 0x7f}, | ||
| }, | ||
| binding.ValidationStage: { | ||
| tableRequest{SpoofGuardTable, 0x7f}, | ||
| }, | ||
| binding.ConntrackStateStage: { | ||
| tableRequest{ConntrackTable, 0x7f}, | ||
| tableRequest{ConntrackStateTable, 0x6f}, | ||
| }, | ||
| binding.RoutingStage: { | ||
| tableRequest{L3ForwardingTable, 0x7f}, | ||
| tableRequest{L3DecTTLTable, 0x7d}, | ||
| }, | ||
| binding.SwitchingStage: { | ||
| tableRequest{L2ForwardingCalcTable, 0x7f}, | ||
| }, | ||
| binding.ConntrackStage: { | ||
| tableRequest{ConntrackCommitTable, 0x7f}, | ||
| }, | ||
| binding.OutputStage: { | ||
| tableRequest{L2ForwardingOutTable, 0x7f}, | ||
| }, | ||
| }, | ||
| } | ||
| for _, ipProtocol := range c.ipProtocols { | ||
| if ipProtocol == binding.ProtocolIPv6 { | ||
| template.stageTables[binding.ValidationStage] = append(template.stageTables[binding.ValidationStage], tableRequest{IPv6Table, 0x7e}) | ||
| break | ||
| } | ||
| } | ||
| } else if protocol == ofProtocolARP { | ||
|
There was a problem hiding this comment. I think here you can use There was a problem hiding this comment. Thanks, updated in #3058 |
||
| template = &pipelineTemplate{ | ||
| stageTables: map[binding.StageID][]tableRequest{ | ||
| binding.ValidationStage: { | ||
| tableRequest{ARPSpoofGuardTable, 0x7f}, | ||
| }, | ||
| binding.OutputStage: { | ||
| tableRequest{ARPResponderTable, 0x7f}, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| return template | ||
| } | ||
|
|
||
| func (c *featureNetworkPolicy) getTemplate(protocol ofProtocol) *pipelineTemplate { | ||
| var template *pipelineTemplate | ||
| if protocol != ofProtocolIP { | ||
| return template | ||
| } | ||
| template = &pipelineTemplate{ | ||
| stageTables: map[binding.StageID][]tableRequest{ | ||
| binding.ValidationStage: { | ||
| tableRequest{SpoofGuardTable, 0x7f}, | ||
| }, | ||
| binding.ConntrackStateStage: { | ||
| tableRequest{SNATConntrackTable, 0xff}, | ||
| }, | ||
| binding.EgressSecurityStage: { | ||
| tableRequest{EgressRuleTable, 0x7f}, | ||
| tableRequest{EgressDefaultTable, 0x7e}, | ||
| tableRequest{EgressMetricTable, 0x7d}, | ||
| }, | ||
| binding.RoutingStage: { | ||
| tableRequest{L3ForwardingTable, 0x7f}, | ||
| }, | ||
| binding.IngressSecurityStage: { | ||
| tableRequest{IngressRuleTable, 0x7f}, | ||
| tableRequest{IngressDefaultTable, 0x7e}, | ||
| tableRequest{IngressMetricTable, 0x7d}, | ||
| }, | ||
| binding.ConntrackStage: { | ||
| tableRequest{ConntrackCommitTable, 0x7f}, | ||
| }, | ||
| }, | ||
| } | ||
| if c.enableAntreaPolicy { | ||
| template.stageTables[binding.EgressSecurityStage] = append(template.stageTables[binding.EgressSecurityStage], | ||
| tableRequest{AntreaPolicyEgressRuleTable, 0x8f}, | ||
| ) | ||
| template.stageTables[binding.IngressSecurityStage] = append(template.stageTables[binding.IngressSecurityStage], | ||
| tableRequest{AntreaPolicyIngressRuleTable, 0x8f}, | ||
| ) | ||
| } | ||
| return template | ||
| } | ||
|
|
||
| func (c *featureService) getTemplate(protocol ofProtocol) *pipelineTemplate { | ||
| var template *pipelineTemplate | ||
| if protocol != ofProtocolIP { | ||
| return template | ||
| } | ||
| if c.enableProxy { | ||
| template = &pipelineTemplate{ | ||
| stageTables: map[binding.StageID][]tableRequest{ | ||
| binding.ConntrackStateStage: { | ||
| tableRequest{SNATConntrackTable, 0xff}, | ||
| }, | ||
| binding.PreRoutingStage: { | ||
| tableRequest{SessionAffinityTable, 0x7f}, | ||
| tableRequest{ServiceLBTable, 0x7e}, | ||
| tableRequest{EndpointDNATTable, 0x7d}, | ||
| }, | ||
| binding.RoutingStage: { | ||
| tableRequest{L3ForwardingTable, 0x7f}, | ||
| tableRequest{ServiceHairpinMarkTable, 0x7e}, | ||
| }, | ||
| binding.PostRoutingStage: { | ||
| tableRequest{SNATConntrackCommitTable, 0x7e}, | ||
| }, | ||
| binding.ConntrackStage: { | ||
| tableRequest{ConntrackCommitTable, 0x7f}, | ||
| }, | ||
| binding.OutputStage: { | ||
| tableRequest{L2ForwardingOutTable, 0x7f}, | ||
| }, | ||
| }, | ||
| } | ||
| if runtime.IsWindowsPlatform() { | ||
| template.stageTables[binding.ValidationStage] = append(template.stageTables[binding.ValidationStage], tableRequest{UplinkTable, 0x8f}) | ||
| } | ||
| if c.proxyAll { | ||
| template.stageTables[binding.PreRoutingStage] = append(template.stageTables[binding.PreRoutingStage], tableRequest{NodePortProbeTable, 0x8f}) | ||
| } | ||
| } else { | ||
| template = &pipelineTemplate{ | ||
| stageTables: map[binding.StageID][]tableRequest{ | ||
| binding.PreRoutingStage: { | ||
| tableRequest{DNATTable, 0x7f}, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
| return template | ||
| } | ||
|
|
||
| func (c *featureEgress) getTemplate(protocol ofProtocol) *pipelineTemplate { | ||
| var template *pipelineTemplate | ||
| if protocol != ofProtocolIP { | ||
| return template | ||
| } | ||
| template = &pipelineTemplate{ | ||
| stageTables: map[binding.StageID][]tableRequest{ | ||
| binding.RoutingStage: { | ||
| tableRequest{L3ForwardingTable, 0x7f}, | ||
| }, | ||
| binding.PostRoutingStage: { | ||
| tableRequest{SNATTable, 0x8f}, | ||
| }, | ||
| }, | ||
| } | ||
| return template | ||
| } | ||
|
|
||
| func (c *featureTraceflow) getTemplate(protocol ofProtocol) *pipelineTemplate { | ||
| var template *pipelineTemplate | ||
| if protocol != ofProtocolIP { | ||
| return template | ||
| } | ||
| template = &pipelineTemplate{} | ||
| return template | ||
| } | ||
|
|
||
| func (c *featureVMConnectivity) getTemplate(protocol ofProtocol) *pipelineTemplate { | ||
| var template *pipelineTemplate | ||
| if protocol != ofProtocolIP { | ||
| return template | ||
| } | ||
| template = &pipelineTemplate{ | ||
| stageTables: map[binding.StageID][]tableRequest{ | ||
| binding.ClassifierStage: { | ||
| tableRequest{ClassifierTable, 0x7f}, | ||
| }, | ||
| binding.ConntrackStateStage: { | ||
| tableRequest{ConntrackStateTable, 0x7f}, | ||
| }, | ||
| binding.ConntrackStage: { | ||
| tableRequest{ConntrackTable, 0x7f}, | ||
| }, | ||
| binding.OutputStage: { | ||
| tableRequest{L2ForwardingOutTable, 0x7f}, | ||
| }, | ||
| }, | ||
| } | ||
| return template | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anywhere we can learn why here is setting as
0x7f? or will there be any update for existing ovs-pipeline design doc? https://github.com/antrea-io/antrea/blob/main/docs/design/ovs-pipeline.mdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. How the table priorities are decided? Should we define constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order of table within a stage is decided by this priority. We don't need to define constants because priorities should be the same within a stage, otherwise the order of tables cannot be decided by priority. @jianjuns @luolanzone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand your explanation. How 0x7f, 0x6f, 0x7d in this file are decided? If I add a new table later, how I decide the priority value?