Realize Egress for a Pod once its network is created #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
added
action/backport
tnqn
force-pushed
the
egress-realization
branch
from
c93a460
to
8697a9d
Compare
|
@Dyanngg Do you remember why it's entityUpdateChannel, instead of podUpdateChannel? I don't find anywhere entity update is published. Is it reserved for future usage? Anyway I think later we could create an externalEntityUpdateChannel when necessary, instead of mixing the channel of PodUpdate. Please let me know if this change breaks anything. |
|
/test-all |
tnqn
force-pushed
the
egress-realization
branch
from
8697a9d
to
053a48c
Compare
|
/test-all |
|
/test-ipv6-all |
tnqn
force-pushed
the
egress-realization
branch
from
053a48c
to
25d0aee
Compare
|
/test-ipv6-e2e |
Codecov Report
@@ Coverage Diff @@
## main #3360 +/- ##
==========================================
- Coverage 60.85% 53.61% -7.25%
==========================================
Files 268 240 -28
Lines 26723 34179 +7456
==========================================
+ Hits 16263 18324 +2061
- Misses 8649 14078 +5429
+ Partials 1811 1777 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
jianjuns
reviewed
Feb 28, 2022
pkg/util/channel/channel.go
Outdated
| type eventHandler func(string) | ||
|
|
||
| type Subscriber interface { | ||
| // Subscribe subscribes an eventHandler which will be called when there is an event sent to the channel. |
pkg/util/channel/channel.go
Outdated
| // Channel is different from the Go channel which dispatches every event to only single consumer regardless of the | ||
| // number of consumers. Instead, it dispatches every event to all consumers by calling the eventHandlers they have | ||
| // registered. | ||
| type Channel struct { |
There was a problem hiding this comment.
Should we use a different name to distinguish from Golang channel? Like SubscriptionChannel.
There was a problem hiding this comment.
does SubscribableChannel make sense to you?
Previously antrea-controller included a Pod in an EgressGroup only when its IP has been presented in K8s API. If a Pod tries to access external right after it's up, Node IP will be used as the SNAT IP even when an Egress applying to it has been created because its Pod IP may haven't been reported to K8s API or antrea-controller may haven't included the Pod in the EgressGroup. This patch fixes it by making CNIServer notify EgressController that it has processed CNI ADD request of a Pod, then EgressController can reconcile the corresponding Egress immediately, instead of waiting for the Pod to be reported to K8s API. As NetworkPolicyController relies on that event as well, we introduce a channel implementation which supports multiple subscribers. Fixes antrea-io#3361 Signed-off-by: Quan Tian <qtian@vmware.com>
|
/test-all |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Mar 10, 2022
Previously antrea-controller included a Pod in an EgressGroup only when its IP has been presented in K8s API. If a Pod tries to access external right after it's up, Node IP will be used as the SNAT IP even when an Egress applying to it has been created because its Pod IP may haven't been reported to K8s API or antrea-controller may haven't included the Pod in the EgressGroup. This patch fixes it by making CNIServer notify EgressController that it has processed CNI ADD request of a Pod, then EgressController can reconcile the corresponding Egress immediately, instead of waiting for the Pod to be reported to K8s API. As NetworkPolicyController relies on that event as well, we introduce a channel implementation which supports multiple subscribers. Fixes antrea-io#3361 Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously antrea-controller included a Pod in an EgressGroup only when
its IP has been presented in K8s API. If a Pod tries to access external
right after it's up, Node IP will be used as the SNAT IP even when an
Egress applying to it has been created because its Pod IP may haven't
been reported to K8s API or antrea-controller may haven't included the
Pod in the EgressGroup.
This patch fixes it by making CNIServer notify EgressController that it
has processed CNI ADD request of a Pod, then EgressController can
reconcile the corresponding Egress immediately, instead of waiting for
the Pod to be reported to K8s API. As NetworkPolicyController relies on
that event as well, we introduce a channel implementation which supports
multiple subscribers.
Fixes #3361
Signed-off-by: Quan Tian qtian@vmware.com