Refine logs with upper case #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3404 +/- ##
==========================================
- Coverage 65.59% 64.66% -0.93%
==========================================
Files 277 277
Lines 27264 27264
==========================================
- Hits 17884 17631 -253
- Misses 7486 7768 +282
+ Partials 1894 1865 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jianjuns
previously approved these changes
Mar 7, 2022
tnqn
reviewed
Mar 8, 2022
| } else if changed { | ||
| klog.InfoS("update ResourceImport for ResoureExport", "resourceimport", resImportName.String(), "resourceexport", req.NamespacedName) | ||
| klog.InfoS("Updating ResourceImport for ResoureExport", "resourceimport", resImportName.String(), "resourceexport", req.NamespacedName) |
There was a problem hiding this comment.
why updating and creating use different level logs?
There was a problem hiding this comment.
I was trying to reduce logs, let me make them consistent.
| @@ -348,7 +348,7 @@ func (r *ResourceExportReconciler) refreshEndpointsResourceImport( | |||
| svcResExport := &mcsv1alpha1.ResourceExport{} | |||
| err := r.Client.Get(ctx, svcResExportName, svcResExport) | |||
| if err != nil && apierrors.IsNotFound(err) { | |||
| return newResImport, false, fmt.Errorf("failed to get corresponding Service type of ResourceExport: " + svcResExportName.String()) | |||
| return newResImport, false, fmt.Errorf("Failed to get corresponding Service type of ResourceExport: " + svcResExportName.String()) | |||
There was a problem hiding this comment.
error message shouldn't be capitalized
|
@tnqn Could you please review again, this is a log refinement, so no hurry to merge it in case it has conflicts with other MC PR, thanks. |
Signed-off-by: Lan Luo <luola@vmware.com>
|
Hi @tnqn, I have rebased this to latest main codes and fix conflicts, it should have no conflicts with other on-going MC PRs, I suppose it can be merged now. thanks. |
tnqn
approved these changes
Mar 24, 2022
|
/test-multicluster-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lan Luo luola@vmware.com