Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4419: Set NO_FLOOD to IPsec tunnel ports #4470: Fix that Service routes may get lost when starting on Windows #4654: Restore NO_FLOOD to OVS ports after reconnecting the OVS #4711: Fix route deletion for Service ClusterIP and LoadBalancerIP #4759

Conversation

luolanzone
Copy link
Contributor

Cherry pick of #4419 #4470 #4654 #4711 on release-1.7.

#4419: Set NO_FLOOD to IPsec tunnel ports
#4470: Fix that Service routes may get lost when starting on Windows
#4654: Restore NO_FLOOD to OVS ports after reconnecting the OVS
#4711: Fix route deletion for Service ClusterIP and LoadBalancerIP

For details on the cherry pick process, see the cherry pick requests page.

xliuxu and others added 3 commits March 24, 2023 15:19
Set NO_FLOOD to IPsec tunnel ports to avoid ARP flooding.

Signed-off-by: Xu Liu <xliu2@vmware.com>
Fix antrea-io#4467

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
The NO_FLOOD configuration is lost when the OVS daemon is restarted.
Currently, the only way to recover this configuration is by restarting
the agent. This pull request adds logic to recover the configuration
when receiving OVS reconnection events.

Signed-off-by: Xu Liu <xliu2@vmware.com>
@luolanzone luolanzone added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #4759 (4ffe36b) into release-1.7 (0037700) will decrease coverage by 21.38%.
The diff coverage is 25.83%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.7    #4759       +/-   ##
================================================
- Coverage        61.76%   40.39%   -21.38%     
================================================
  Files              298      258       -40     
  Lines            44437    39306     -5131     
================================================
- Hits             27446    15877    -11569     
- Misses           14803    21907     +7104     
+ Partials          2188     1522      -666     
Flag Coverage Δ
kind-e2e-tests 40.39% <25.83%> (-8.47%) ⬇️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/interfacestore/types.go 69.44% <0.00%> (ø)
pkg/agent/util/net.go 27.62% <0.00%> (-21.02%) ⬇️
pkg/agent/proxy/proxier.go 44.01% <14.92%> (-18.30%) ⬇️
...gent/controller/noderoute/node_route_controller.go 35.95% <20.00%> (-19.81%) ⬇️
pkg/agent/route/route_linux.go 26.09% <33.33%> (-20.57%) ⬇️
pkg/agent/agent.go 44.48% <40.00%> (-9.20%) ⬇️
pkg/agent/interfacestore/interface_cache.go 82.87% <75.00%> (-2.13%) ⬇️

... and 189 files with indirect coverage changes

@luolanzone luolanzone force-pushed the automated-cherry-pick-of-#4419-#4470-#4654-#4711-upstream-release-1.7 branch from eea9bb8 to 49f98bd Compare March 27, 2023 08:39
When proxyAll is enabled, AntreaProxy needs to install routes in the
host network namespace to redirect traffic to OVS for load balancing.
For a Service with multiple ports, multiple ServicePorts are generated
and processed. The previous code installed the route for a ClusterIP or
a LoadBalancerIP multiple times when such a Service was created, and
uninstalled the route multiple times when it was deleted, leading to a
few problems.

This patch adds a serviceIPRouteReferences which tracks the references
of Service IPs' routes. The key is the Service IP and the value is the
the set of ServiceInfo strings. With the references, we install a route
exactly once as long as it's used by any ServicePorts and uninstall it
exactly once when it's no longer used by any ServicePorts.

This patch also fixes an issue that the route for ClusterIP was not
removed on Windows Nodes after the Service was removed.

Fixes antrea-io#4361

Signed-off-by: Quan Tian <qtian@vmware.com>
@luolanzone luolanzone force-pushed the automated-cherry-pick-of-#4419-#4470-#4654-#4711-upstream-release-1.7 branch from 49f98bd to 4ffe36b Compare March 27, 2023 10:33
@luolanzone luolanzone closed this Mar 27, 2023
@luolanzone luolanzone deleted the automated-cherry-pick-of-#4419-#4470-#4654-#4711-upstream-release-1.7 branch March 28, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants