[Multicast] Add Support for FlexibleIPAM #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
19 times, most recently
from
62c63b0
to
a6fdaf3
Compare
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
11 times, most recently
from
b8b1d72
to
68a54a5
Compare
|
/test-multicast-e2e |
|
/test-flexible-ipam-e2e |
1 similar comment
|
/test-flexible-ipam-e2e |
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
from
668cdd0
to
ca3179a
Compare
|
/test-multicast-e2e |
1 similar comment
|
/test-multicast-e2e |
|
/test-flexible-ipam-e2e |
1 similar comment
|
/test-flexible-ipam-e2e |
|
/test-multicast-e2e |
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
2 times, most recently
from
bb7f642
to
59bf237
Compare
tnqn
reviewed
Dec 5, 2023
pkg/agent/openflow/pipeline.go
Outdated
| // send multicast packets to access the external receivers. For the case that one or more local Pods have joined the target | ||
| // multicast group, it is handled by the flows created by function "localMulticastForwardFlows" after local Pods report the | ||
| // IGMP membership. | ||
| // externalMulticastReceiverFlow generates the flow to output multicast packets to Antrea gateway interface(to the host interface |
There was a problem hiding this comment.
Suggested change
| // externalMulticastReceiverFlow generates the flow to output multicast packets to Antrea gateway interface(to the host interface | |
| // externalMulticastReceiverFlow generates the flow to output multicast packets to Antrea gateway interface (and the host interface |
There was a problem hiding this comment.
Updated. Personally, I think in the parentheses, the phrase to the host interface and the uplink interface when flexibleIPAM is enabled is more reasonable to me.
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
from
59bf237
to
3a5fae9
Compare
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
from
3a5fae9
to
fe594a7
Compare
|
/test-multicast-e2e |
|
/test-flexible-ipam-e2e |
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
from
fe594a7
to
ccc30e9
Compare
|
/test-multicast-e2e |
|
/test-flexible-ipam-e2e |
When FlexibleIPAM is enabled for the cluster. Inbound multicast traffic will be forwarded to MulticastRoutingTable. Outbound multicast traffic will forward to local ports, the uplink interface, and the host interface. Signed-off-by: ceclinux <src655@gmail.com>
ceclinux
force-pushed
the
flexible-ipam-multicast
branch
from
ccc30e9
to
92e4648
Compare
|
/test-flexible-ipam-e2e |
|
/test-multicast-e2e |
|
Hi @tnqn . Could you take time to have another look? Thanks. |
|
/skip-all |
tnqn
added
the
action/release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FlexibleIPAM is enabled for the cluster, inbound multicast traffic will
be forwarded to MulticastRoutingTable. Outbound multicast traffic will
forward to local ports, the uplink interface, and the host interface.