Promote ExternalIPPool API to v1beta1 #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
27 tasks
hongliangl
force-pushed
the
20230626-upgrade-api-externalip
branch
4 times, most recently
from
0cb2e0f
to
ed933bb
Compare
luolanzone
added
api-review
hongliangl
force-pushed
the
20230626-upgrade-api-externalip
branch
from
ed933bb
to
aa33db1
Compare
luolanzone
reviewed
Jul 7, 2023
hongliangl
force-pushed
the
20230626-upgrade-api-externalip
branch
from
aa33db1
to
1a1683e
Compare
antoninbas
reviewed
Jul 13, 2023
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
force-pushed
the
20230626-upgrade-api-externalip
branch
from
1a1683e
to
53dc300
Compare
luolanzone
reviewed
Jul 18, 2023
There was a problem hiding this comment.
LGTM overall @hongliangl please address the latest comment of api.md, so we can move forward.
|
/test-all |
antoninbas
reviewed
Jul 18, 2023
| type: array | ||
| matchLabels: | ||
| additionalProperties: | ||
| type: string |
There was a problem hiding this comment.
This PR has been merged, but I wonder why we use a specific pattern above for label values, but not here?
@tnqn @hongliangl
There was a problem hiding this comment.
I didn't know additionalProperties can support pattern attribute, didn't see such example in docs. But I just took a try, and pattern works for additionalProperties too.
@hongliangl could you follow up with an enhancement PR?
shi0rik0
pushed a commit
to shi0rik0/antrea
that referenced
this pull request
Jul 19, 2023
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
shi0rik0
pushed a commit
to shi0rik0/antrea
that referenced
this pull request
Jul 19, 2023
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
XinShuYang
pushed a commit
to XinShuYang/antrea
that referenced
this pull request
Jul 20, 2023
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.