Revise antctl mc deploy to support manifest update
#5257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianjuns
changed the title
antctl mc deploy to support manifest updateantctl mc deploy to support manifest update
jianjuns
reviewed
Jul 17, 2023
luolanzone
force-pushed
the
refine-mc-deploy
branch
from
7fdf16a
to
dcce1d7
Compare
|
In commit message, consider changing "Refine" to "Revise". "If the CRD is already existing" -> If a CRD to import already exists" |
luolanzone
commented
Jul 18, 2023
luolanzone
force-pushed
the
refine-mc-deploy
branch
from
dcce1d7
to
715a9c4
Compare
|
Commit title and message are updated. |
jianjuns
reviewed
Jul 18, 2023
In our manifests, there are both CRDs and CRs (Service/Deployment etc), so maybe I can rewrite it as |
luolanzone
force-pushed
the
refine-mc-deploy
branch
from
715a9c4
to
f01a02b
Compare
|
I feel you should just say "a resource to create". |
luolanzone
force-pushed
the
refine-mc-deploy
branch
from
f01a02b
to
58a7cff
Compare
Updated the message. Thanks. |
jianjuns
approved these changes
Jul 20, 2023
|
/test-multicluster-e2e |
If a resource to create already exists, the command `antctl mc deploy` will do nothing even when the manifests are changed. Revise the code to apply changes if there is any manifest update. Signed-off-by: Lan Luo <luola@vmware.com>
luolanzone
force-pushed
the
refine-mc-deploy
branch
from
58a7cff
to
e3419db
Compare
|
Rebased and rerun the test. |
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource to create already exists, the command
antctl mc deploywill do nothing even when the manifests are changed. Revise the code to apply changes if there is any manifest update.