Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix antctl traceflow using IPv6 address #5588

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix antctl traceflow using IPv6 address #5588

merged 1 commit into from
Oct 17, 2023

Conversation

Atish-iaf
Copy link
Contributor

Fixes #5541

@Atish-iaf Atish-iaf added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2023
@Atish-iaf Atish-iaf marked this pull request as ready for review October 17, 2023 06:51
@rajnkamr rajnkamr added this to the Antrea v1.14 release milestone Oct 17, 2023
@Atish-iaf Atish-iaf added area/component/antctl Issues or PRs releated to the command line interface component area/transit/ipv6 Issues or PRs related to IPv6. area/ops/traceflow Issues or PRs related to the Traceflow feature labels Oct 17, 2023
tnqn
tnqn previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Oct 17, 2023

/test-e2e
/skip-conformance
/skip-networkpolicy

luolanzone
luolanzone previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment nit.

pkg/antctl/raw/traceflow/command.go Outdated Show resolved Hide resolved
@Atish-iaf
Fix antctl traceflow using IPv6 address
e20fb94 
Fixes antrea-io#5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
@Atish-iaf Atish-iaf dismissed stale reviews from luolanzone and tnqn via e20fb94 October 17, 2023 13:53
@Atish-iaf Atish-iaf force-pushed the fix-ipv6-address-in-antctl-traceflow branch from fc52ce8 to e20fb94 Compare October 17, 2023 13:53
@Atish-iaf
Copy link
Contributor Author

/test-e2e
/skip-conformance
/skip-networkpolicy

@Atish-iaf Atish-iaf requested a review from tnqn October 17, 2023 14:17
@Atish-iaf
Copy link
Contributor Author

/test-e2e

@antoninbas antoninbas merged commit f7c941d into antrea-io:main Oct 17, 2023
45 of 55 checks passed
@antoninbas antoninbas added the action/release-note Indicates a PR that should be included in release notes. label Oct 17, 2023
@antoninbas
Copy link
Contributor

@Atish-iaf should this be backported to Antrea v1.13 and v1.12?

This was referenced Oct 18, 2023
Merged
Merged
@Atish-iaf Atish-iaf added the action/backport Indicates a PR that requires backports. label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

@luolanzone luolanzone luolanzone left review comments

@rajnkamr rajnkamr Awaiting requested review from rajnkamr

@tnqn tnqn Awaiting requested review from tnqn

Assignees
No one assigned
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. area/component/antctl Issues or PRs releated to the command line interface component area/ops/traceflow Issues or PRs related to the Traceflow feature area/transit/ipv6 Issues or PRs related to IPv6. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
Antrea v1.14 release
Development

Successfully merging this pull request may close these issues.

IPv6 address in traceflow using antctl CLI doesn't work
5 participants
@Atish-iaf @tnqn @antoninbas @luolanzone @rajnkamr