Set net.ipv4.conf.antrea-gw0.arp_announce to 1 #5657
Conversation
|
/test-flexible-ipam-e2e |
pkg/agent/agent.go
Outdated
| @@ -730,6 +730,11 @@ func (i *Initializer) setupGatewayInterface() error { | |||
| if err := i.setInterfaceMTU(i.hostGateway, i.networkConfig.InterfaceMTU); err != nil { | |||
| return err | |||
| } | |||
| if i.nodeConfig.GatewayConfig.IPv4 != nil { | |||
| if err := i.setInterfaceARPAnnounce(gatewayIface.InterfaceName, 1); err != nil { | |||
There was a problem hiding this comment.
Please add comment why this is needed
There was a problem hiding this comment.
Added comment and PR description about this context.
luolanzone
added
the
action/release-note
gran-vmv
force-pushed
the
ipam-arp
branch
2 times, most recently
from
b65af14
to
2c59098
Compare
|
/test-flexible-ipam-e2e |
gran-vmv
added
kind/bug
pkg/agent/agent.go
Outdated
| @@ -730,6 +730,15 @@ func (i *Initializer) setupGatewayInterface() error { | |||
| if err := i.setInterfaceMTU(i.hostGateway, i.networkConfig.InterfaceMTU); err != nil { | |||
| return err | |||
| } | |||
| // Fix #5451 | |||
There was a problem hiding this comment.
Typically no need to link issue in code file when the comment can explain the code. Otherwise the code file would be full of issue links.
There was a problem hiding this comment.
Removed issue link.
pkg/agent/agent.go
Outdated
| // Set arp_announce to 1 on Linux platform to make the ARP requests from host to gateway | ||
| // interface always use gateway IP as source IP. These ARP requests without gateway IP will |
There was a problem hiding this comment.
"the ARP requests from host to gateway interface" doesn't sound correct.
Set arp_announce to 1 on Linux platform to make the ARP requests sent on the gateway interface always use the gateway IP as the source IP, otherwise the ARP requests would be dropped by ARP SpoofGuard flow.
There was a problem hiding this comment.
Updated code comment, commit message and PR description.
Fix antrea-io#5451 Set arp_announce to 1 on Linux platform to make the ARP requests sent on the gateway interface always use the gateway IP as the source IP, otherwise the ARP requests would be dropped by ARP SpoofGuard flow. Signed-off-by: gran <gran@vmware.com>
|
/test-flexible-ipam-e2e |
|
/test-networkpolicy |
|
@gran-vmv please backport it to 1.12-1.14 |
Fix #5451
Set arp_announce to 1 on Linux platform to make the ARP requests sent on the gateway
interface always use the gateway IP as the source IP, otherwise the ARP requests would be
dropped by ARP SpoofGuard flow.