Fix Endpoint Querier RuleIndex In Response #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Dec 11, 2023
| // an AddressGroup can only be referenced in a rule once | ||
| break | ||
| } | ||
| } | ||
| // ingressIndex/egressIndex indicates the rule index among this policy's ingress/egress rules | ||
| // Antrea Native NP rules priorities are set as index, but KNP rules have the same default rule priorities |
There was a problem hiding this comment.
I don't understand the reference to "priorities" here. This seems like a regular index to me.
There was a problem hiding this comment.
+1. Please also add comments on why the index increment is removed from the original place as well
There was a problem hiding this comment.
Updated the comments.
antoninbas
added
kind/bug
|
Probably no need to backport since this has been the behavior for a very long time, unless someone is asking for it. |
qiyueyao
force-pushed
the
fix-querier-index
branch
from
e3e0d16
to
8c00792
Compare
Sure, it's just needed for #5740 . Thanks! |
The current endpoint querier rule index shows the index of the rule among all matched rules in the policy for this endpoint, which is not super useful for the users. This change updates the rule index to show the rule index among all rules in the policy. Fixes antrea-io#5782 Signed-off-by: Qiyue Yao <yaoq@vmware.com>
qiyueyao
force-pushed
the
fix-querier-index
branch
from
8c00792
to
c1faf9b
Compare
antoninbas
approved these changes
Dec 11, 2023
|
/test-all |
Dyanngg
approved these changes
Dec 11, 2023
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current endpoint querier rule index shows the index of the rule among all matched rules in the original policy for this endpoint.
This change updates the rule index to show the rule index among all rules in the original policy.
Fixes #5782