Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Local ExternalTrafficPolicy for Services with ExternalIPs #5795

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Support Local ExternalTrafficPolicy for Services with ExternalIPs #5795

merged 1 commit into from
Dec 14, 2023

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Dec 13, 2023 •
edited

Since K8s 1.29, setting Local ExternalTrafficPolicy for ClusterIP Services with ExternalIPs is supported.

For #5792

@tnqn tnqn added area/proxy Issues or PRs related to proxy functions in Antrea action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. labels Dec 13, 2023
@tnqn tnqn mentioned this pull request Dec 13, 2023
Closed
5 tasks
antoninbas
antoninbas approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

typo in the PR description: s/ExteralIPs/ExternalIPs

@tnqn
Support Local ExternalTrafficPolicy for Services with ExternalIPs
b7507bc 
Since K8s 1.29, setting Local ExternalTrafficPolicy for ClusterIP
Services with ExternalIPs is supported.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn
Copy link
Member Author

tnqn commented Dec 14, 2023

typo in the PR description: s/ExteralIPs/ExternalIPs

fixed, thanks

@tnqn
Copy link
Member Author

tnqn commented Dec 14, 2023

/test-all

hongliangl
hongliangl approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@hongliangl hongliangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member Author

tnqn commented Dec 14, 2023

e2e is well tested on kind, the jenkins job failed due to image pulling error.
/skip-e2e

@tnqn tnqn merged commit 9ce147d into antrea-io:main Dec 14, 2023
50 of 53 checks passed
@tnqn tnqn deleted the support-clusterip-etp branch December 14, 2023 05:06
This was referenced Jan 8, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

@hongliangl hongliangl hongliangl approved these changes

Assignees
No one assigned
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. area/proxy Issues or PRs related to proxy functions in Antrea
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tnqn @antoninbas @hongliangl