Remove the dependency of openssl library in antrea-controller image #5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainpulkit22
force-pushed
the
apiserver-e2e
branch
from
7d2374e
to
59f0f2c
Compare
luolanzone
reviewed
Jan 9, 2024
luolanzone
reviewed
Jan 9, 2024
jainpulkit22
force-pushed
the
apiserver-e2e
branch
from
59f0f2c
to
fb139cf
Compare
tnqn
reviewed
Jan 9, 2024
jainpulkit22
force-pushed
the
apiserver-e2e
branch
from
fb139cf
to
5766024
Compare
No, we are not installing openssl only for test, openssl is getting installed as a part of the ovs image(so, ovs might have some dependency on openssl), and we are using the ovs image when building the antrea-agent image so openssl is already a part of antrea-agent, so for that reason I used the above approach. |
antoninbas
reviewed
Jan 10, 2024
luolanzone
reviewed
Jan 11, 2024
jainpulkit22
force-pushed
the
apiserver-e2e
branch
from
5766024
to
b7d55f6
Compare
rajnkamr
reviewed
Jan 11, 2024
jainpulkit22
force-pushed
the
apiserver-e2e
branch
2 times, most recently
from
24c238c
to
4713b8e
Compare
antoninbas
reviewed
Jan 16, 2024
luolanzone
reviewed
Jan 17, 2024
jainpulkit22
force-pushed
the
apiserver-e2e
branch
2 times, most recently
from
ea4e44c
to
7e436b0
Compare
tnqn
reviewed
Jan 17, 2024
jainpulkit22
force-pushed
the
apiserver-e2e
branch
from
7e436b0
to
063236f
Compare
antoninbas
reviewed
Jan 17, 2024
Configured a toolbox pod to run the e2e test TestAntreaApiserverTLSConfig. Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22
force-pushed
the
apiserver-e2e
branch
from
063236f
to
dfc2da7
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestAntreaApiserverTLSConfig, this e2e test requires the openssl command to be installed in antrea-controller and antrea-agent pod, but adding openssl library to the antrea-controller image unnecessarily increases the size of the antrea-controller image, so I have leveraged the the openssl library which is already installed in the antrea-agent image to perform the e2e test.