Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failure when running 'kubectl cp' #6271

Closed
wants to merge 1 commit into from

Conversation

luolanzone
Copy link
Contributor

In some CI jobs, e.g. whole-conformance, a failure tar: antrea-agent.cov.out: file changed as we read it happened occasionally, the failure is caused by kubectl cp, this actually a warning from tar and can be ignored instead of failing the job since the test is actually passed.

@luolanzone luolanzone requested a review from tnqn April 28, 2024 06:12
@luolanzone luolanzone added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2024
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this error mean that we could be uploading a corrupted coverage file to codecov, or is it truly harmless?

ci/jenkins/test-mc.sh Outdated Show resolved Hide resolved
@luolanzone
Copy link
Contributor Author

Does this error mean that we could be uploading a corrupted coverage file to codecov, or is it truly harmless?

I think it should be harmless, this issue doesn't happen frequently, I feel it's OK to not have the right coverage data for one or two PRs.

@antoninbas
Copy link
Contributor

Does this error mean that we could be uploading a corrupted coverage file to codecov, or is it truly harmless?

I think it should be harmless, this issue doesn't happen frequently, I feel it's OK to not have the right coverage data for one or two PRs.

If kubectl cp fails with this error, do you know if any file is created on the host? If not, then I don't have a concern. We want to make sure that run_codecov doesn't fail because of an invalid file, otherwise isn't that change pointless?

BTW, thinking about it some more, do you think that we should also add a short sleep (maybe just 1s) before running the kubectl cp command? It may be enough to get rid of the issue. We could have both (the sleep and || true to ignore a possible error).

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone
Copy link
Contributor Author

@antoninbas I submitted another PR to fix kubectl cp issue here #6387, maybe we can on-hold this PR to see if the same kubectl cp with tar failure happens in the future considering the coverage related codes changes a lot.

@luolanzone luolanzone closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants