Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has-changes doesn't work as expected #7

Closed
tnqn opened this issue Mar 25, 2022 · 2 comments · Fixed by #8
Closed

has-changes doesn't work as expected #7

tnqn opened this issue Mar 25, 2022 · 2 comments · Fixed by #8
Assignees
@antoninbas

Comments

@tnqn
Copy link
Member

tnqn commented Mar 25, 2022 •
edited
Loading

It return yes somehow when all changed files match the ignore_patterns. "hack/.notableofcontents" is mismatched:

PATHS: *
IGNORE_PATHS: docs/* ci/jenkins/* *.md hack/.notableofcontents plugins/*

...

* Changed files are:
docs/antctl.md
docs/multicluster/antctl.md
hack/.notableofcontents
* Changed files after filtering with patterns are:
docs/antctl.md docs/multicluster/antctl.md hack/.notableofcontents
* Changed files after filtering with ignore_patterns are:
hack/.notableofcontents
Setting 'has_changes' to 'yes'

See the following builds:
https://github.com/antrea-io/antrea/runs/5692577240?check_suite_focus=true
https://github.com/antrea-io/antrea/runs/5692570263?check_suite_focus=true

However, I cannot reproduce the issue by calling check_changes.sh directly, not sure what's wrong.
@antoninbas
Copy link
Contributor

Thanks for reporting this, I'll see if I can figure it out

@antoninbas antoninbas self-assigned this Mar 25, 2022
antoninbas added a commit to antoninbas/has-changes that referenced this issue Mar 25, 2022
@antoninbas
Expand arrays to single word when calling check_changes
489f225 
Otherwise array contents are passed as individual words and the input
parameters are mangled and lost.

Fixes antrea-io#7

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas mentioned this issue Mar 25, 2022
Merged
antoninbas added a commit that referenced this issue Mar 25, 2022
@antoninbas
Expand arrays to single word when calling check_changes (#8)
51b9cae 
Otherwise array contents are passed as individual words and the input
parameters are mangled and lost.

Fixes #7

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas
Copy link
Contributor

@tnqn it should be fixed now

The v2 tag now points to the v2.0.1 release which means Antrea should pick up the change automatically.

@tnqn tnqn mentioned this issue Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand arrays to single word when calling check_changes antoninbas/has-changes
2 participants
@antoninbas @tnqn