Allocate 6 bytes to copy MAC addresses when unmarshalling ethernet match fields #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch fields Currently we are trying to unmarshal data to an uninitialized struct whose net.HardwareAddr fields are set to nil. In this case the copy() function silently does nothing. Initialize the fields to slices of bytes of length 6 before copying data to them. Signed-off-by: Dmitry Rozhkov <dmitry.rojkov@gmail.com>
|
Hi @rojkov thanks for working on this patch. I have one comment on this patch: OpenFlow 1.5 is the major version we planned to support for a long time ( OpenFlow1.3 is deprecated ), so please also change the code in path |
shi0rik0
added a commit
to shi0rik0/libOpenflow
that referenced
this pull request
Jul 11, 2023
…tch fields Currently we are trying to unmarshal data to an uninitialized struct whose net.HardwareAddr fields are set to nil. In this case the copy() function silently does nothing. Initialize the fields to slices of bytes of length 6 before copying data to them. This commit is derived from antrea-io#30. Signed-off-by: shi0rik0 <anguuan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are trying to unmarshal data to an uninitialized struct whose
net.HardwareAddrfields are set to nil. In this case thecopy()function silently does nothing.Initialize the fields to slices of bytes of length 6 before copying data to them.
Signed-off-by: Dmitry Rozhkov dmitry.rojkov@gmail.com