New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@antv/f2-vue): 增强对自定义图形及自定义图表组件的JSX编译支持 #1538
Conversation
大多数情况下编译JSX不再需要使用@babel/plugin-transform-react-jsx。备注:自定义图表组件需引用@antv/f2-vue中的自定义函数,例如:import { withLegend } from "@antv/f2-vue"。 close #1573
This pull request introduces 4 alerts when merging dff74ff into c013297 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging faff337 into c013297 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 7220457 into c013297 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 4f6318d into c013297 - view on LGTM.com new alerts:
|
…used in render() or setup()
This pull request introduces 4 alerts when merging 365fd2d into e7e0b16 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
This pull request introduces 4 alerts when merging a45b086 into e7e0b16 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 0a3612b into e7e0b16 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging a344e93 into e7e0b16 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 512b424 into e7e0b16 - view on LGTM.com new alerts:
|
感谢 PR,最近比较忙,我今天看下 |
This pull request introduces 8 alerts when merging 4d382e9 into e7e0b16 - view on LGTM.com new alerts:
|
8 for Unused variable, import, function or class
@zengyue 如果review的过程中需要我,请随时联系。 |
解决Vue3项目中编译包含自定义View及自定义Shape时需要使用@babel/plugin-transform-react-jsx的问题。详见examples中的vue3-ts项目示例。
备注:自定义图表组件需引用@antv/f2-vue中的HOC。例如:
import { withLegend } from "@antv/f2-vue"
。close #1573
Checklist
npm test
passesDescription of change