Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@antv/f2-vue): 增强对自定义图形及自定义图表组件的JSX编译支持 #1538

Closed
wants to merge 20 commits into from

Conversation

lolarun
Copy link

@lolarun lolarun commented Jul 9, 2022

解决Vue3项目中编译包含自定义View及自定义Shape时需要使用@babel/plugin-transform-react-jsx的问题。详见examples中的vue3-ts项目示例。
备注:自定义图表组件需引用@antv/f2-vue中的HOC。例如: import { withLegend } from "@antv/f2-vue"

close #1573

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

大多数情况下编译JSX不再需要使用@babel/plugin-transform-react-jsx。备注:自定义图表组件需引用@antv/f2-vue中的自定义函数,例如:import {
withLegend } from "@antv/f2-vue"。

close #1573
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2022

This pull request introduces 4 alerts when merging dff74ff into c013297 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2022

This pull request introduces 4 alerts when merging faff337 into c013297 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 10, 2022

This pull request introduces 4 alerts when merging 7220457 into c013297 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2022

This pull request introduces 4 alerts when merging 4f6318d into c013297 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2022

This pull request introduces 4 alerts when merging 365fd2d into e7e0b16 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

packages/vue/test/canvas/graphic.test.tsx Show resolved Hide resolved
packages/vue/test/canvas/graphic.test.tsx Show resolved Hide resolved
packages/vue/test/canvas/graphic.test.tsx Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2022

This pull request introduces 4 alerts when merging a45b086 into e7e0b16 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2022

This pull request introduces 4 alerts when merging 0a3612b into e7e0b16 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2022

This pull request introduces 4 alerts when merging a344e93 into e7e0b16 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2022

This pull request introduces 4 alerts when merging 512b424 into e7e0b16 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@zengyue
Copy link
Contributor

zengyue commented Jul 26, 2022

感谢 PR,最近比较忙,我今天看下

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2022

This pull request introduces 8 alerts when merging 4d382e9 into e7e0b16 - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class

8 for Unused variable, import, function or class
@lolarun lolarun requested a review from accesslint August 3, 2022 14:31
@lolarun lolarun marked this pull request as draft August 3, 2022 14:32
@lolarun lolarun marked this pull request as ready for review August 3, 2022 14:34
@lolarun
Copy link
Author

lolarun commented Aug 10, 2022

@zengyue 如果review的过程中需要我,请随时联系。

@lolarun lolarun changed the title feat(@antv/f2-vue): 增加自定义图形及自定义图表组件的JSX编译支持 feat(@antv/f2-vue): 增加自定义图形及自定义图表组件的JSX的支持 Aug 12, 2022
@lolarun lolarun changed the title feat(@antv/f2-vue): 增加自定义图形及自定义图表组件的JSX的支持 feat(@antv/f2-vue): 增强自定义图形及自定义图表组件的JSX的支持 Aug 12, 2022
@lolarun lolarun changed the title feat(@antv/f2-vue): 增强自定义图形及自定义图表组件的JSX的支持 feat(@antv/f2-vue): 增强自定义图形及自定义图表组件的支持(JSX/TSX) Aug 12, 2022
@lolarun lolarun changed the title feat(@antv/f2-vue): 增强自定义图形及自定义图表组件的支持(JSX/TSX) feat(@antv/f2-vue): 增强对自定义图形及自定义图表组件的支持(JSX/TSX) Aug 12, 2022
@lolarun lolarun changed the title feat(@antv/f2-vue): 增强对自定义图形及自定义图表组件的支持(JSX/TSX) feat(@antv/f2-vue): 增强对自定义图形及自定义图表组件的JSX/TSX编译支持 Aug 18, 2022
@lolarun lolarun changed the title feat(@antv/f2-vue): 增强对自定义图形及自定义图表组件的JSX/TSX编译支持 feat(@antv/f2-vue): 增强对自定义图形及自定义图表组件的JSX编译支持 Aug 18, 2022
@lolarun lolarun closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants