fix: geom repaint

src/chart/chart.js

@@ -307,6 +307,9 @@ class Chart extends Base {
   }
 
   _initGeom(geom) {
+    if (geom.get('isInit')) {
+      return;
+    }
     const coord = this.get('coord');
     const data = this.get('filteredData');
     const colDefs = this.get('colDefs');
@@ -577,10 +580,14 @@ class Chart extends Base {
     const canvas = this.get('canvas');
     const geoms = this.get('geoms');
 
-    if (!rendered) {
+    // 已经渲染过
+    if (rendered) {
+      this._initGeoms();
+    } else {
       this.init();
       this.set('rendered', true);
     }
+
     this.emit(EVENT_BEFORE_RENDER);
 
     Chart.plugins.notify(this, 'beforeGeomDraw');
@@ -756,13 +763,8 @@ class Chart extends Base {
    * @param {Geom} geom geometry instance
    */
   addGeom(geom) {
-    const rendered = this.get('rendered');
     const geoms = this.get('geoms');
     geoms.push(geom);
-    // 如果图表已经渲染过了，则直接初始化geom
-    if (rendered) {
-      this._initGeom(geom);
-    }
   }
 
   /**

src/geom/base.js

@@ -74,14 +74,21 @@ class Geom extends Base {
       visible: true,
       connectNulls: false,
       // 是否丢弃没有值的分组。
-      ignoreEmptyGroup: false
+      ignoreEmptyGroup: false,
+      // 是否已经初始化
+      isInit: false
     };
   }
 
   init() {
     const self = this;
+    const isInit = self.get('isInit');
+    if (isInit) {
+      return;
+    }
     self._initAttrs();
     self._processData();
+    self.set('isInit', true);
   }
 
   _getGroupScales() {
@@ -794,6 +801,7 @@ class Geom extends Base {
     this.set('data', data);
     // 改变数据后，情况度量，因为需要重新实例化
     this.set('scales', {});
+    this.set('isInit', false);
     this.init();
   }
 
@@ -806,6 +814,7 @@ class Geom extends Base {
   }
 
   reset() {
+    this.set('isInit', false);
     this.set('attrs', {});
     this.set('attrOptions', {});
     this.set('adjust', null);
@@ -817,6 +826,7 @@ class Geom extends Base {
   }
 
   destroy() {
+    this.set('isInit', false);
     this.clear();
     super.destroy();
   }

test/unit/geom/geom-init-spec.js

@@ -0,0 +1,61 @@
+const expect = require('chai').expect;
+const Chart = require('../../../src/chart/chart');
+
+require('../../../src/geom/index');
+
+describe('Geom init', function() {
+
+  const canvas = document.createElement('canvas');
+  canvas.width = 500;
+  canvas.height = 500;
+  document.body.appendChild(canvas);
+  let chart;
+
+  it('repetition Geom', function() {
+
+    chart = new Chart({
+      el: canvas
+    });
+
+    const data = [
+      {
+        date: '2020-05-10',
+        dailyProfit: '0.00',
+        profit: -15.69
+      },
+      {
+        date: '2020-05-20',
+        dailyProfit: '0.00',
+        profit: 15.69
+      },
+      {
+        date: '2020-06-10',
+        dailyProfit: '0.00',
+        profit: 115.69
+      },
+      {
+        date: '2020-07-10',
+        dailyProfit: '0.00',
+        profit: 215.69
+      }
+    ];
+
+
+    chart.source(data);
+    chart.axis('date', {
+      label: false
+    });
+
+    chart.line().position('date*profit');
+    expect(chart.get('geoms')[0].get('isInit')).to.be.false;
+    chart.render();
+    expect(chart.get('geoms').length).equal(1);
+    expect(chart.get('geoms')[0].get('isInit')).to.be.true;
+    chart.line().position('date*profit');
+    chart.render();
+
+    expect(chart.get('geoms').length).equal(2);
+
+  });
+
+});

test/unit/geom/geom-spec.js

@@ -235,11 +235,13 @@ describe('test geoms', function() {
       ];
       geom.set('data', data);
       geom.position('a*b').color('c');
+      geom.set('isInit', false);
       geom.init();
       const dataArray = geom.get('dataArray');
       expect(dataArray.length).equal(4);
 
       geom.set('ignoreEmptyGroup', true);
+      geom.set('isInit', false);
       geom.init();
       const dataArray1 = geom.get('dataArray');
       expect(dataArray1.length).equal(2);