Skip to content

Commit

Permalink
fix: remove whiteSpace from Text
Browse files Browse the repository at this point in the history
  • Loading branch information
xiaoiver committed Sep 15, 2022
1 parent 6c5da59 commit 901dde9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/g/src/__tests__/css/initial.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ describe('StyleValueRegistry initialization', () => {
expect(text.getAttribute('lineHeight')).to.be.eqls('');
expect(text.getAttribute('lineWidth')).to.be.eqls('');
expect(text.getAttribute('miterLimit')).to.be.eqls('');
expect(text.getAttribute('whiteSpace')).to.be.eqls('pre');
// expect(text.getAttribute('whiteSpace')).to.be.eqls('pre');
expect(text.getAttribute('wordWrap')).to.be.eqls(false);
expect(text.getAttribute('leading')).to.be.eqls(0);
expect(text.getAttribute('dx')).to.be.eqls('');
Expand Down
1 change: 0 additions & 1 deletion packages/site/docs/guide/advanced-topics/container.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ addPropertiesHandler<number, number>(
'leading',
'textBaseline',
'textAlign',
'whiteSpace',
],
undefined,
undefined,
Expand Down
1 change: 0 additions & 1 deletion packages/site/docs/guide/advanced-topics/container.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ addPropertiesHandler<number, number>(
'leading',
'textBaseline',
'textAlign',
'whiteSpace',
],
undefined,
undefined,
Expand Down
11 changes: 5 additions & 6 deletions packages/site/examples/shape/demo/text.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ const multilineConfig = {
lineHeight: 0,
leading: 0,
textAlign: 'start',
whiteSpace: 'pre',
};
multilineFolder.add(multilineConfig, 'breakWords').onChange((breakWords) => {
text.attr('breakWords', breakWords);
Expand Down Expand Up @@ -285,11 +284,11 @@ multilineFolder
.onChange((textAlign) => {
text.attr('textAlign', textAlign);
});
multilineFolder
.add(multilineConfig, 'whiteSpace', ['pre', 'normal', 'pre-line'])
.onChange((whiteSpace) => {
text.attr('whiteSpace', whiteSpace);
});
// multilineFolder
// .add(multilineConfig, 'whiteSpace', ['pre', 'normal', 'pre-line'])
// .onChange((whiteSpace) => {
// text.attr('whiteSpace', whiteSpace);
// });

const transformFolder = gui.addFolder('transform');
const transformConfig = {
Expand Down

0 comments on commit 901dde9

Please sign in to comment.