Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isDisplayObject should account for null & undefined value #1272

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Jan 17, 2023

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

πŸ’‘ Background and solution

εŽ»ι™€ instanceof εˆ€ζ–­ζ—ΆοΌŒδ½Ώη”¨ηš„ isDisplayObject ιœ€θ¦θ€ƒθ™‘ null ε’Œ undefined

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English
πŸ‡¨πŸ‡³ Chinese

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

 - @antv/g-camera-api@1.0.26
 - @antv/g-canvas@1.9.28
 - @antv/g-canvaskit@0.8.28
 - @antv/g-components@1.7.37
 - @antv/g-css-layout-api@1.0.26
 - @antv/g-css-typed-om-api@1.0.26
 - @antv/g-devtool@0.10.37
 - @antv/g-dom-mutation-observer-api@1.0.26
 - @antv/g-gesture@0.0.63
 - @antv/g-image-exporter@0.5.38
 - @antv/g-layout-blocklike@1.7.37
 - @antv/g-lite@1.0.33
 - @antv/g-lottie-player@0.0.26
 - @antv/g-math@1.7.37
 - @antv/g-mobile-canvas-element@0.6.37
 - @antv/g-mobile-canvas@0.8.37
 - @antv/g-mobile-svg@0.8.36
 - @antv/g-mobile-webgl@0.7.43
 - @antv/g-pattern@1.0.7
 - @antv/g-plugin-3d@1.7.39
 - @antv/g-plugin-a11y@0.4.37
 - @antv/g-plugin-annotation@0.2.36
 - @antv/g-plugin-box2d@1.7.38
 - @antv/g-plugin-canvas-path-generator@1.1.39
 - @antv/g-plugin-canvas-picker@1.8.37
 - @antv/g-plugin-canvas-renderer@1.7.42
 - @antv/g-plugin-canvaskit-renderer@1.1.40
 - @antv/g-plugin-control@1.7.37
 - @antv/g-plugin-css-select@1.7.38
 - @antv/g-plugin-device-renderer@1.7.42
 - @antv/g-plugin-dom-interaction@1.7.38
 - @antv/g-plugin-dragndrop@1.6.37
 - @antv/g-plugin-gpgpu@1.7.37
 - @antv/g-plugin-html-renderer@1.7.39
 - @antv/g-plugin-image-loader@1.1.40
 - @antv/g-plugin-matterjs@1.7.38
 - @antv/g-plugin-mobile-interaction@0.7.37
 - @antv/g-plugin-physx@1.7.38
 - @antv/g-plugin-rough-canvas-renderer@1.7.40
 - @antv/g-plugin-rough-svg-renderer@1.7.40
 - @antv/g-plugin-svg-picker@1.7.38
 - @antv/g-plugin-svg-renderer@1.8.36
 - @antv/g-plugin-webgl-device@1.7.38
 - @antv/g-plugin-webgpu-device@1.7.37
 - @antv/g-plugin-yoga@1.7.37
 - @antv/g-plugin-zdog-canvas-renderer@1.0.5
 - @antv/g-plugin-zdog-svg-renderer@1.0.3
 - @antv/g-shader-components@1.7.37
 - @antv/g-svg@1.8.36
 - @antv/g-web-animations-api@1.0.26
 - @antv/g-web-components@1.7.37
 - @antv/g-webgl@1.7.43
 - @antv/g-webgpu@1.7.42
 - @antv/g@5.15.13
 - @antv/react-g@1.8.41
@xiaoiver xiaoiver merged commit 28bb962 into next Jan 17, 2023
@xiaoiver xiaoiver deleted the fix-clone branch January 17, 2023 10:56
@coveralls
Copy link

coveralls commented Jan 17, 2023

Pull Request Test Coverage Report for Build 3938510877

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 72.556%

Totals Coverage Status
Change from base Build 3937297680: 0.01%
Covered Lines: 5625
Relevant Lines: 7231

πŸ’› - Coveralls

@xiaoiver
Copy link
Contributor Author

πŸŽ‰ This PR is included in version @antv/g-gesture-v2.1.0-beta.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@xiaoiver
Copy link
Contributor Author

πŸŽ‰ This PR is included in version @antv/g-gesture-v2.1.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants