Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-canvas): strokeText should be invoked before fillText for Text #299

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

dengfuping
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

before after
image image

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix incorrect rendering for Text when stroke and fill coexist. #298
🇨🇳 Chinese 🐞 [g-canvas] 修复 Text 在描边和填充共存时,渲染不正确的问题。#298

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 9, 2019

Deploy preview for antv-g ready!

Built with commit 0bfe8df

https://deploy-preview-299--antv-g.netlify.com

@dengfuping dengfuping merged commit 7e8a03a into master Dec 11, 2019
@dengfuping dengfuping deleted the fix-issue-298 branch December 11, 2019 10:43
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-canvas): strokeText should be invoked before fillText for Text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.0] text 的文本描边和填充效果不佳,同 3.x 的表现不一致
1 participant