Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(g-canvas & g-svg): add getStartTangent() and getEndTangent() method for Polyline #329

Merged
merged 1 commit into from
Dec 20, 2019
Merged

feat(g-canvas & g-svg): add getStartTangent() and getEndTangent() method for Polyline #329

merged 1 commit into from
Dec 20, 2019

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Dec 20, 2019 •
edited
Loading

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

πŸ’‘ Background and solution

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English 🌟 [g-canvas & g-svg] Add getStartTangent() and getEndTangent() method for Polyline. #295
πŸ‡¨πŸ‡³ Chinese 🌟 [g-canvas & g-svg] Polyline ζ–°ε’ž getStartTangent() and getEndTangent() ζˆε‘˜ζ–Ήζ³•γ€‚#295

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

tests-checker[bot]
tests-checker bot suggested changes Dec 20, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 20, 2019 •
edited
Loading

Deploy preview for antv-g ready!

Built with commit adb7230

https://deploy-preview-329--antv-g.netlify.com

@dengfuping dengfuping merged commit 9876584 into master Dec 20, 2019
@dengfuping dengfuping deleted the feat-polyline branch December 20, 2019 10:48
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
@dengfuping
Merge pull request antvis#329 from antvis/feat-polyline
7be8009 
feat(g-canvas & g-svg): add getStartTangent() and getEndTangent() method for Polyline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

Assignees
No one assigned
Labels
enhancement PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dengfuping