fix: coordinate.rotate use Radian

antvis · Feb 6, 2020 · 124f380 · 124f380
1 parent d223b0d
commit 124f380
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/chart/controller/coordinate.ts b/src/chart/controller/coordinate.ts
@@ -88,22 +88,37 @@ export default class {
     return this.coordinate;
   }
 
+  /**
+   * 旋转弧度
+   * @param angle
+   */
   public rotate(angle: number) {
-    angle = angle * Math.PI / 180;
     this.option.actions.push([ 'rotate', angle ]);
     return this;
   }
 
+  /**
+   * 镜像
+   * @param dim
+   */
   public reflect(dim: string) {
     this.option.actions.push([ 'reflect', dim ]);
     return this;
   }
 
+  /**
+   * scale
+   * @param sx
+   * @param sy
+   */
   public scale(sx: number, sy: number) {
     this.option.actions.push([ 'scale', sx, sy ]);
     return this;
   }
 
+  /**
+   * 对角变换
+   */
   public transpose() {
     this.option.actions.push([ 'transpose' ]);
     return this;

diff --git a/tests/unit/chart/controller/coordinate-spec.ts b/tests/unit/chart/controller/coordinate-spec.ts
@@ -18,7 +18,7 @@ describe('test coordinate controller', () => {
     expect(actions.length).toBe(1);
     expect(actions[0]).toEqual([ 'transpose' ]);
 
-    controller.rotate(180);
+    controller.rotate(Math.PI);
     expect(actions.length).toBe(2);
     expect(actions[1]).toEqual([ 'rotate', Math.PI ]);
 
@@ -31,7 +31,7 @@ describe('test coordinate controller', () => {
     expect(actions[3]).toEqual([ 'reflect', 'x' ]);
   });
 
-  it('create coord', () => {
+  it('create coordinate', () => {
     const coordinate = controller.create({ x: 0, y: 0 }, { x: 500, y: 500 });
     expect(coordinate.isTransposed).toBe(true);
   });