Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5]what the base type for .line() .interval #4672

Closed
coader opened this issue Feb 20, 2023 · 2 comments · Fixed by #4689
Closed

[v5]what the base type for .line() .interval #4672

coader opened this issue Feb 20, 2023 · 2 comments · Fixed by #4689
Assignees
Labels
Milestone

Comments

@coader
Copy link

coader commented Feb 20, 2023

I have a chart and it whould dynamic change type:
let mark:????
if (type=='line')
mark=chart.line()
else if (type=='interval')
mark=chart.interval()

how to define the mark type in typescript?

@pearmini
Copy link
Member

That's a good issue. The base type of mark should be exported. @pepper-nice

And it may change the name from MarkBase to Mark.

@pearmini pearmini added the V5 label Feb 20, 2023
@pearmini pearmini added this to the 5.0.0-beta.11 milestone Feb 20, 2023
@coader
Copy link
Author

coader commented Feb 20, 2023

tks, it will be useful to encapsulate chart as vue component

@pearmini pearmini modified the milestones: 5.0.0-beta.11, 5.0.0-beta.12 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants