Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interval support lineCap round #3036

Merged
merged 9 commits into from Nov 30, 2020
Merged

feat: interval support lineCap round #3036

merged 9 commits into from Nov 30, 2020

Conversation

yujs
Copy link
Contributor

@yujs yujs commented Nov 22, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@github-actions
Copy link

github-actions bot commented Nov 22, 2020

😭 Deploy PR Preview 91ad046 failed. Build logs

🤖 By surge-preview

@yujs
Copy link
Contributor Author

yujs commented Nov 22, 2020

interval支持.style({lineCap:'round'})

@coveralls
Copy link

coveralls commented Nov 22, 2020

Pull Request Test Coverage Report for Build 389526175

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 26 of 31 (83.87%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 93.396%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/geometry/shape/interval/util.ts 16 21 76.19%
Files with Coverage Reduction New Missed Lines %
src/animate/animation/sector-path-update.ts 1 93.07%
Totals Coverage Status
Change from base Build 375928306: 0.02%
Covered Lines: 10569
Relevant Lines: 10973

💛 - Coveralls

@hustcc hustcc merged commit 2907ac7 into master Nov 30, 2020
@hustcc hustcc deleted the feat/interval_cap branch November 30, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants