Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto hide legend padding #3104

Merged
merged 2 commits into from Dec 11, 2020
Merged

fix auto hide legend padding #3104

merged 2 commits into from Dec 11, 2020

Conversation

lessmost
Copy link
Member

@lessmost lessmost commented Dec 10, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change
  1. 调整坐标轴标签默认的 autoHide 配置,默认开启 autoHide,并设置最小间距 6px
before after
image image
  1. 调整图例的默认 padding,使得图例和图形对齐
    • 可通过主题分别对水平布局的图例和垂直布局的图例分别配置 padding
    • 默认的 light/dark 主题设置合适的 padding
before after
image image

@github-actions
Copy link

github-actions bot commented Dec 10, 2020

😭 Deploy PR Preview e64bc5f failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 413046297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 93.374%

Files with Coverage Reduction New Missed Lines %
src/chart/controller/gesture.ts 7 82.14%
Totals Coverage Status
Change from base Build 410134101: -0.07%
Covered Lines: 10673
Relevant Lines: 11084

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Dec 10, 2020

Axis label 默认间距多少?

@lessmost
Copy link
Member Author

Axis label 默认间距多少?

6px

@hustcc hustcc merged commit f4dc16e into master Dec 11, 2020
@hustcc hustcc deleted the fix-auto-hide-legend-padding branch December 11, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants