Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attr): add attribute class #3391

Merged
merged 6 commits into from
Apr 26, 2021
Merged

feat(attr): add attribute class #3391

merged 6 commits into from
Apr 26, 2021

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Apr 25, 2021

Checklist
  • attribute
  • testcase
Description of change

增加 attribute 方法,不在分包,其实是针对 scale 的的 attribute 概念封装!

@coveralls
Copy link

coveralls commented Apr 25, 2021

Pull Request Test Coverage Report for Build 782494200

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 49 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+7.6%) to 7.625%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/util/attribute.ts 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/geometry/attribute/size.ts 1 42.86%
src/geometry/attribute/indentity.ts 2 44.44%
src/geometry/attribute/shape.ts 3 40.0%
src/geometry/attribute/position.ts 7 21.74%
src/geometry/attribute/color.ts 8 36.84%
src/geometry/attribute/attribute.ts 28 12.0%
Totals Coverage Status
Change from base Build 782242050: 7.6%
Covered Lines: 35
Relevant Lines: 362

💛 - Coveralls

@hustcc hustcc merged commit 88f079e into v5 Apr 26, 2021
@hustcc hustcc deleted the feat-attr branch April 26, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants